Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Use the word "in" as alias for "to" in conversions #38

Open
sebastian-65 opened this issue Apr 18, 2022 · 6 comments
Open

[feature] Use the word "in" as alias for "to" in conversions #38

sebastian-65 opened this issue Apr 18, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@sebastian-65
Copy link

When 20 cm in inches is typed, I would expect the same result as for 20 cm to inches. (The same syntax is supported by Google search, so I'm used to it.)

Would be possible to add support for this as well? Thanks!

@sebastian-65 sebastian-65 added the enhancement New feature or request label Apr 18, 2022
@lgg
Copy link

lgg commented Apr 22, 2022

Really good idea, like it!

@sebastian-65
Copy link
Author

sebastian-65 commented Apr 23, 2022

Also it would be nice to accept 20€ or 20 € same way as dollar sign, e.g. 20 $.

@tchar
Copy link
Owner

tchar commented Apr 24, 2022

Hello,

Initially, the program took into account "in" as a keyword, but I opted to remove it because it was causing problems. The reason is that it can be interpreted as inches, so while you type if you write something like the following:

10 m in to kg: This can be interpreted as:

  • 10 meters -> tons kilograms
  • 10 meters inches -> kilograms

This might not be the best example but it is not easy to differentiate between in and to. I can try adding this back but I remember it was not a decision I liked but rather necessary to simplify things.

Because this project grew a bit and I don't have the time right now due to job requirements, I welcome anyone to do a PR with tests, etc if you want to contribute. In fact, I would be glad to have more people join this.

@sebastian-65
Copy link
Author

Thank you for your reply. I definitely see this might cause such issues. How about those euros?

I would love to contribute, however since I'm writing my first python scripts, you wouldn't be exactly pleased with results 😅 I hope I could write things like this in the future.

@tchar
Copy link
Owner

tchar commented Apr 27, 2022

Thank you for your reply. I definitely see this might cause such issues. How about those euros?

I would love to contribute, however since I'm writing my first python scripts, you wouldn't be exactly pleased with results 😅 I hope I could write things like this in the future.

@sebastian-65
For the space in currency I have to check how to implement. I use pint for unit conversion and currency conversion. I have to check if pint can handle these.

However, this project is on hold for now. I am having a time shortage since I finished the main project and I don't know when I can continue the implementation.

@github-actions
Copy link

Issue has been marked as stale due to no activity

@github-actions github-actions bot added the stale label Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants