Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespaced module #73

Closed
OnceUponALoop opened this issue Feb 14, 2024 · 3 comments
Closed

Support namespaced module #73

OnceUponALoop opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@OnceUponALoop
Copy link

Description

Catesta does not support a namespaced module name (ex. MyModule.Utils)

Describe the solution you'd like

Simply support module names with a dot/period.

Describe any alternatives you've considered

Additional context

At a glance, it seems a simple change to Module.build.ps1 $ModuleName parsing will address this.

From
$ModuleName = (Split-Path -Path $BuildFile -Leaf).Split('.')[0]
and $script:ModuleName = (Split-Path -Path $BuildFile -Leaf).Split('.')[0]

To
$ModuleName = ((Get-Item $BuildFile).BaseName) -replace ".build$"
and $script:ModuleName = ((Get-Item $BuildFile).BaseName) -replace ".build$"

@OnceUponALoop OnceUponALoop added the enhancement New feature or request label Feb 14, 2024
@techthoughts2 techthoughts2 self-assigned this Apr 12, 2024
@techthoughts2
Copy link
Owner

Great suggestion.
Will be included in the next release.

@OnceUponALoop
Copy link
Author

I'm sorry I didn't update sooner, one other place where I found manual intervention was required was the vscode tasks.json - I couldn't find a good solution for it though, I ended up manually editing it (shrug)

I had to manually edit workspaceFolderBasename through find and replace

@techthoughts2
Copy link
Owner

@OnceUponALoop

I tested and the tasks.json tasks are working as expected.
workspaceFolderBasename does expect that the base folder name to be the module name.

Can you open a new issue with the details of the error you are getting, or a suggestion to improve if its not clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants