-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AM242 specification in the blueprints #1757
Comments
@keckler It appears to me that armi/armi/nucDirectory/tests/test_nuclideBases.py Lines 249 to 250 in 9dc6760
It appears Thoughts? |
Yeah, I think that is fine. But then we should not allow |
I could do that. We could also throw a loud warning that the nuclide you entered is being renamed, and loudly inform people this is just a convenience pass-through for them. |
A little research showed me that While many projects are already correctly using Thoughts? |
Interesting. I know that I am responsible for at least some of that. I would be willing to migrate anytime that a change is made here. I think a good path here is to move towards deprecation, starting with a warning. Maybe in the next-next release, we drop it? |
So, this whole situation is, it turns out, extremely well documented in the code: armi/armi/nucDirectory/nuclideBases.py Lines 630 to 637 in 93a7a94
armi/armi/nucDirectory/nuclideBases.py Lines 1295 to 1327 in 93a7a94
But there isn't any (good or pleasant) way to inject a |
There is a bit of an inconsistency in the different sections of the blueprints when it comes to specifying the isotope AM242.
The
nuclide flags
portion of the blueprints allows you to putAM242
without complaining. But then if you putAM242
into one of your components, the run will fail during blueprints instantiation. For instance, using the attached input files which have AM242 in both the nuclide flags and a custom material:To get this error to go away, you have to change the
AM242
in the custom material into eitherAM242M
orAM242G
.The error is raised here:
armi/armi/reactor/blueprints/componentBlueprint.py
Lines 320 to 362 in b3a9992
If you look into that
nucsInProblem
set, which is derived from the nuclide flags in the blueprints, you'll find that it hasAM242G
andAM242M
in it, but not plain oldAM242
like was specified by the user:So somewhere in the problem initialization, the
AM242
nuclide flag is converted intoAM242G
andAM242M
. But this makes is confusing if one tries to simply enter nuclide flags for the isotopes corresponding to their materials.If we are going to force users to use
AM242M
andAM242G
, then we should do so consistently.example-blueprints.yaml.txt
example.yaml.txt
The text was updated successfully, but these errors were encountered: