Allow pin pitch in HexBlock
s to fall back to pitch defined by a grid
#1765
Labels
HexBlock
s to fall back to pitch defined by a grid
#1765
The pin pitch is gotten by
HexBlock.getPinPitch()
by examining the clad and wire dimensions:armi/armi/reactor/blocks.py
Lines 2420 to 2464 in 8768dec
This implicitly assumes that every
HexGrid
has a wire wrap. This is not universally true. It also assumes that there is only one type of clad and one type of wire in the block. This is certainly not universally true.If we look at the parent class method,
Block.getPinPitch()
will actually check if the block has a grid defined, and it will use that to get the pin pitch within the block:armi/armi/reactor/blocks.py
Lines 1270 to 1276 in 8768dec
This implementation on the parent class allows for the pin pitch to be gathered, independent of the assumptions that I outlined above. It just requires the user to define a grid in the blueprints.
I propose that the
HexBlock
subclass ofgetPinPitch()
falls back to the parent method implementation if it fails to find the pin pitch using the current method. So basically just adding anothertry/except
clause in there, and then pointing tosuper().getPinPitch()
. This would allow for a lot more flexibility in geometric definition.The text was updated successfully, but these errors were encountered: