-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the-turk-diff.forum.differences
and the-turk-diff.forum.previewMode
are untranslatable in some languages
#7
Comments
Are those differences happens because of sentences? What about these:
Because those advices that you linked will took us here eventually. |
It looks unnatural, and I'm not sure how to translate it to be hones. These differences are because of sentences, but you can still keep sentence format and give some flexibility to translators. You have at least 2 options:
|
I talked with @clarkwinkelmann on Discord and he suggested this:
That sounds like a perfect solution. What do you think? That was my last example by the way: |
I would still prefer solution 2 with complete phrases for each combination (redundancy is not a problem from my perspective), but this should be fine too. |
Second suggestion simplifies the translation process but complicates the backend and causes repetitive code parts over and over. Clark's suggestion was relatively easy to implement and I believe it will solve this issue for most of languages. v1.0.4 is ready for release and will solve this issue (here are some related lines) but I also want to hear from @littlegolden. I don't think these changes will effect their translations since they already have translated the extension for both Simple Chinese & Japanese languages but who knows maybe they have another issue that dissatisfies them. |
Thanks! v1.0.4 released. |
You're reusing some translations (
the-turk-diff.forum.originalContent
,the-turk-diff.forum.currentContent
,the-turk-diff.forum.revisionWithNumber
) to generate messages fromthe-turk-diff.forum.differences
andthe-turk-diff.forum.previewMode
. But in Polishthe-turk-diff.forum.differences
andthe-turk-diff.forum.previewMode
creates completely different context and requires different translations forthe-turk-diff.forum.originalContent
,the-turk-diff.forum.currentContent
,the-turk-diff.forum.revisionWithNumber
.Examples:
the-turk-diff.forum.differences:
EN: You're viewing differences between original content and revision 3.
PL: Przeglądasz różnice pomiędzy originalną treścią i rewizją nr 3
the-turk-diff.forum.previewMode:
EN: You're previewing original content
PL: Przeglądasz oryginalną treść
EN: You're previewing revision 3
PL: Przeglądasz rewizję nr 3
As you can see
the-turk-diff.forum.originalContent
andthe-turk-diff.forum.revisionWithNumber
requires different translations forthe-turk-diff.forum.differences
and different forthe-turk-diff.forum.previewMode
(originalną treścią
vsoryginalną treść
andrewizją nr 3
vsrewizję nr 3
). Please create separate strings for these 2 cases (see Reuse Translations, Not Keys!) or avoid joining strings in this way completely (see Avoid Hardcoded Syntax!).The text was updated successfully, but these errors were encountered: