Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip color for deleted revisions is supposed to be red #9

Closed
the-turk opened this issue Apr 14, 2020 · 0 comments
Closed

Tooltip color for deleted revisions is supposed to be red #9

the-turk opened this issue Apr 14, 2020 · 0 comments
Assignees
@the-turk
Labels
bug Something isn't working
Milestone
1.0.5

Comments

@the-turk
Copy link
Owner

Bug Report

Current Behavior
If you hover over any deleted revision in revision list, you'll see black colored tooltip instead of red.

Steps to Reproduce

  1. Edit a post
  2. Delete any revision's content
  3. Hover over any deleted revision in revision list
  4. Tooltip has black background

Expected Behavior
Tooltip's background color for deleted revisions should be red instead of black.

Screenshots

Environment

  • Extension version: 1.0.4

Possible Solution
Replace this line:

flarum-diff/js/src/forum/components/DiffList.js

Line 154 in 0230881

tooltipClass + 'deletedDiffTooltip'

with:

tooltipClass + ' deletedDiffTooltip'
@the-turk the-turk added the bug Something isn't working label Apr 14, 2020
@the-turk the-turk added this to the 1.0.5 milestone Apr 14, 2020
@the-turk the-turk self-assigned this Apr 14, 2020
@the-turk the-turk changed the title Tooltip colors for deleted revisions supposed to be red Tooltip color for deleted revisions was supposed to be red Apr 14, 2020
@the-turk the-turk changed the title Tooltip color for deleted revisions was supposed to be red Tooltip color for deleted revisions is supposed to be red Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@the-turk the-turk

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
1 participant
@the-turk