Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessagePack Serialization Fails #42

Open
GammaSoul opened this issue Jun 12, 2023 · 1 comment
Open

MessagePack Serialization Fails #42

GammaSoul opened this issue Jun 12, 2023 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@GammaSoul
Copy link

GammaSoul commented Jun 12, 2023

Describe the bug
Hi there im having some trouble with your library
Using MessagePack (https://github.com/neuecc/MessagePack-CSharp) fails
The application hangs and then i get the error:
Error Wrong Credentials
Handshake with server failed.
Apart from the having to use the standard MessagePack resolver Serializer because there is some types of object to be serialized, it fails once that is resolved.
I need to serialize some types like NodaTime and others that MessagePack supports. Also MessagePack has the best performance.

Update:
When using the included Bson Serialization and i enclose my types in a data contract object then it works. does not work if the type is a raw method parameter.

So this is really just about supporting MessagePack for performance as i got Bson to work with my Types.
.
Thank you for having a look at this if you can 👍

@theRainbird theRainbird self-assigned this Aug 24, 2023
@theRainbird
Copy link
Owner

Hi GammaSoul,

MessagePack is difficult to implement, because you have to decorate every type that is serialized with attributes ([MessagePackObject] and [Key]) or provide other metadata. CoreRemoting has some internal classes that describe messages. This classes are serialized using the plugged in serializer. Because this classes are not decorated with MessagePack stuff, serialization fails.

@theRainbird theRainbird added the wontfix This will not be worked on label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants