Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install does not install required dependencies #46

Closed
pravirkr opened this issue Nov 1, 2020 · 1 comment
Closed

pip install does not install required dependencies #46

pravirkr opened this issue Nov 1, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pravirkr
Copy link

pravirkr commented Nov 1, 2020

While doing a fresh install from the git repo as suggested in docs,
pip install git+https://github.com/thepetabyteproject/your.git
I get the following error:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-ee84oxd9/setup.py", line 5, in <module>
        import your
      File "/tmp/pip-req-build-ee84oxd9/your/__init__.py", line 1, in <module>
        from your.writer import *
      File "/tmp/pip-req-build-ee84oxd9/your/writer.py", line 9, in <module>
        from rich.progress import Progress
    ModuleNotFoundError: No module named 'rich'
    ----------------------------------------

The easy solution is to add more info to the installation instructions (e.g. to use the requirements.txt). A long-term fix can be to define the version either in setup.py or in a separate configuration file.

This issue is part of my review for JOSS.

@devanshkv devanshkv self-assigned this Nov 1, 2020
@devanshkv devanshkv added the bug Something isn't working label Nov 1, 2020
@devanshkv
Copy link
Member

Fixed with 136e2cd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants