Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper Review #49

Closed
4 tasks done
pravirkr opened this issue Nov 1, 2020 · 1 comment
Closed
4 tasks done

Paper Review #49

pravirkr opened this issue Nov 1, 2020 · 1 comment
Assignees

Comments

@pravirkr
Copy link

pravirkr commented Nov 1, 2020

The submitted draft looks great! Few comments:

  • fast radio transients like pulsars -> I do not think pulsars should be classified as transients; maybe add giant pulses or single-pulse from pulsars
  • "streamline the pipeline" -> search pipeline?
  • "candidate events:" -> candidate events,
  • Fix citation for Astropy (missing @ in astropy:2018)

Other suggestions:

  • citation for Heimdall -> I prefer B. R. Barsdell thesis as the more appropriate citation for Heimdall than the usually cited reference in the literature (which has more to do with dedisp)

This issue is part of my JOSS review.

@KshitijAggarwal
Copy link
Collaborator

Made the suggested changed with 24e2e15

For "fast radio transients like pulsars": I guess it is a personal preference. I think of them as fast transients which are periodic. Each pulse would still be a transient. I've modified it to ".. like pulsar single pulses, ..."

For "candidate events:" as we are listing some analysis that can be done on the candidate events, I think a colon is better here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants