Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to another CI? #50

Closed
devanshkv opened this issue Nov 1, 2020 · 2 comments
Closed

Move to another CI? #50

devanshkv opened this issue Nov 1, 2020 · 2 comments
Assignees

Comments

@devanshkv
Copy link
Member

Should we consider moving to another CI service like Circle or Travis? Github Actions keep breaking.
I ran the action associated with the commit 136e2cd in a brand new conda env, and it works just fine.

@KshitijAggarwal
Copy link
Collaborator

I seem to have tracked down what's happening (maybe). This is also causing our pip install git+https://github.com/thepetabyteproject/your.git to fail.

SciencePlots require matplotlib while installing. It requires matplotlib already installed. Using pip -r requirements.txt installs all packages together, not serially. So even if matplotlib is written before SciencePlots, it won't be present when SciencePlots is being installed. One thing still not clear to me is that SciencePlots already has matplotlib in its install_requires. So pip should first install matplotlib first, before it tries to run the setup.py of SciencePlots.

A possible discussion of something similar is here: pypa/pip#1386

The solution is to somehow install matplotlib before we try to install SciencePlots.

@KshitijAggarwal
Copy link
Collaborator

Removed SciencePlots with 97e3f86, and everything works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants