Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS files compiled in development mode instead of production #8

Closed
Ralkage opened this issue Sep 26, 2020 · 2 comments
Closed

JS files compiled in development mode instead of production #8

Ralkage opened this issue Sep 26, 2020 · 2 comments
Assignees
@therealsujitk
Labels
bug Something isn't working

Comments

@Ralkage
Copy link
Contributor

Ralkage commented Sep 26, 2020

Hey there 👋

Just recently ran Clark's migrate to Flarum scanner on my forum and from the results, it looks as if the JS for your extension is still compiled for dev mode.

image

Would you be able to fix that? I really like using this extension :)
@therealsujitk
Copy link
Owner

I'm really happy you like my extension 😇. I'm a little busy with exams right now, I hope you don't mind waiting a bit. I will be able to fix this tomorrow night or on monday at the latest.

@therealsujitk therealsujitk self-assigned this Sep 27, 2020
@therealsujitk therealsujitk added the bug Something isn't working label Sep 27, 2020
@therealsujitk
Copy link
Owner

@Ralkage the issue should be fixed in v1.4.9. Thanks for bringing this to my attention!

@therealsujitk therealsujitk changed the title JS compiled for development mode and not prod JS files compiled in development mode instead of production Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@therealsujitk therealsujitk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ralkage @therealsujitk