Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May have Window Version? #43

Open
happydentist opened this issue Feb 27, 2022 · 5 comments
Open

May have Window Version? #43

happydentist opened this issue Feb 27, 2022 · 5 comments

Comments

@happydentist
Copy link

Nice program!
Can have Window Version?

@theryangeary
Copy link
Owner

Sure, I can work on adding a Windows binary. In the meantime it should be easy to build from source on windows. If that's not the case let me know!

@pfmoore
Copy link
Contributor

pfmoore commented Apr 13, 2022

I just had a go trying to build on Windows, but I can't even check the repo out 🙁 It appears there's a test file test/choose_-4:-2.txt, and that's an invalid filename on Windows (the colon is used for drive letters). There's a few other files with colons in the name, too.

I think these files are only used in the e2e_test.sh file, which is unfortunate as that doesn't even work on Windows. Would it be possible to rename those files? I could submit a PR, if that would be acceptable, but I'd have to set up a Unix environment to do so...

@pfmoore
Copy link
Contributor

pfmoore commented Apr 13, 2022

FWIW, I managed to extract all the files except the problematic ones from the zip of master that github provides. With that extract, the code builds fine on Windows and passes cargo test. So it appears that apart from the test file names, everything else works fine 🙂

@pfmoore
Copy link
Contributor

pfmoore commented Apr 13, 2022

I created #45 to rename the test files to make the repository cloneable on Windows.

@ggrothendieck
Copy link

I was able to install this on Windows by installing rust and then running cargo install choose .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants