Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PETSc with original ad_wrapper is computing wrong gradients #20

Open
SNMS95 opened this issue Jul 22, 2023 · 1 comment
Open

PETSc with original ad_wrapper is computing wrong gradients #20

SNMS95 opened this issue Jul 22, 2023 · 1 comment

Comments

@SNMS95
Copy link
Collaborator

SNMS95 commented Jul 22, 2023

This has to be fixed!

We may need to keep short gradient checks for each function to detect where the leak is happening.
@tianjuxue
Copy link
Owner

I think this is a problem with PETSc not converging. If you look at the logging information, the solver did not converge at all. So gradient computation will definitely be wrong.

I have a feeling that this is due to PETSc using 32-bit rather than 64-bit. If you have some time, please explore. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

20-petsc-with-original-ad_wrapper-is-computing-wrong-gradients tianjuxue/jax-am
2 participants
@tianjuxue @SNMS95