Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Music update broke Nuvola integration #656

Closed
theli-ua opened this issue Oct 22, 2020 · 25 comments
Closed

Amazon Music update broke Nuvola integration #656

theli-ua opened this issue Oct 22, 2020 · 25 comments
Assignees
Labels
type: bug Something is not working as expected or the documentation is incorrect.

Comments

@theli-ua
Copy link

Describe the bug

Amazon updated music.amazon.com website and nuvola integration no longer works.

Current status is not updated in mpris, next/prev/play/pause no longer work

@a-m-s
Copy link

a-m-s commented Oct 22, 2020

Works for me, but I'm using music.amazon.co.uk. Maybe it's different?

@jiri-janousek jiri-janousek added need info Assignee needs more information to work on this ticket. type: bug Something is not working as expected or the documentation is incorrect. labels Oct 22, 2020
@theli-ua
Copy link
Author

At least in they US I am seeing this new (frankly, quite ugly) UI: https://imgur.com/dJz86fo

@a-m-s
Copy link

a-m-s commented Oct 23, 2020

Yup, that's different. :-(

I'm just about to go away on vacation, so I won't be able to fix it right away.

@a-m-s
Copy link

a-m-s commented Oct 23, 2020

If I go to music.amazon.com it just forwards me to music.amazon.co.uk. Some sort of VPN setup will be needed to reproduce this issue. :-(

@a-m-s
Copy link

a-m-s commented Oct 23, 2020

I wonder if we have one of those A-B test or phased roll-out deals going on here?

@jiri-janousek
Copy link
Member

jiri-janousek commented Oct 24, 2020

If I go to music.amazon.com it just forwards me to music.amazon.co.uk. Some sort of VPN setup will be needed to reproduce this issue. :-(

If you need a VPN service, I can provide you access to Private Internet Access VPN provider. I pay for it from Nuvola funds.

@jiri-janousek
Copy link
Member

@theli-ua, is there any way to disable the new UI? It isn't uncommon to enable the new design but let users disable it in preferences until the new design is fully tested.

@theli-ua
Copy link
Author

No, there is no such option.

@domdfcoding
Copy link

For me the UK site has now changed to the new dark theme.

@jiri-janousek jiri-janousek removed the need info Assignee needs more information to work on this ticket. label Oct 29, 2020
@halcyon22
Copy link

Same problem for me (USA user). I don't see a way to go back to the old UI.

@theli-ua
Copy link
Author

theli-ua commented Nov 4, 2020

Since there hasn't been any progress here yet
I kinda started trying to update this. https://github.com/theli-ua/nuvola-app-amazon-cloud-player
I got artist/title/prev/next/pause/play/volume working so far.

I'm not sure I'll have time to properly wrap this up though

@jiri-janousek
Copy link
Member

Thanks @theli-ua, @a-m-s will look at it once he returns from vacation.

@ams-cs
Copy link

ams-cs commented Nov 9, 2020

I see the new interface now. I just need to find time to get to it.

@theli-ua
Copy link
Author

theli-ua commented Nov 9, 2020

I see the new interface now. I just need to find time to get to it.

Did you get a chance to look at my PR ?

@ams-cs
Copy link

ams-cs commented Nov 9, 2020

Sorry, no, I missed that. I've got most of it done now.
Only seeking left to do, I think.

@theli-ua
Copy link
Author

theli-ua commented Nov 9, 2020

Sorry, no, I missed that. I've got most of it done now.
Only seeking left to do, I think.

Thats fine. As long as the upstream gets fixed. I have everything working in that PR for what its worth. (including seeking)

@a-m-s
Copy link

a-m-s commented Nov 9, 2020

OK, I've pushed the fix (forgot to add the issue number to the commit, sorry).

I kept most of what I had already done, but I stole the maestro stuff from @theli-ua (that made life easier, thanks!)

I think it's all working. Getting the volume change to show in the interface is a bit ugly, but it works.

@a-m-s
Copy link

a-m-s commented Nov 9, 2020

@fenryxo Do you want me to make an issue for release 5.11?

@theli-ua
Copy link
Author

theli-ua commented Nov 9, 2020

but I stole the maestro stuff from @theli-ua (that made life easier, thanks!)

Getting the volume change to show in the interface is a bit ugly, but it works.

Well, why don't you also just take the volume part of it as well? The code and behaviour look just so much cleaner without popping up a volume slider in the UI

@theli-ua
Copy link
Author

theli-ua commented Nov 9, 2020

@a-m-s btw, setting volume via maestro did change volume slider in the UI for me. (unless its already visible, in which case it would be updated if hidden and shown again). to be honest I don't think its worth it to support updating slider if its already visible, I don't really see a meaningful use case for that

@a-m-s
Copy link

a-m-s commented Nov 10, 2020

Ugh, the Circle CI build fails because "maestro" is defined outside the module, which fails the "standard" check (I fixed all the other issues already).

How can I fix that? (I'm not a Javascript expert.)

@jiri-janousek
Copy link
Member

Do you want me to make an issue for release 5.11?

Yes, please.

Ugh, the Circle CI build fails because "maestro" is defined outside the module, which fails the "standard" check (I fixed all the other issues already).

How can I fix that? (I'm not a Javascript expert.)

You can add /* global maestro */ to the top of the script.

@a-m-s
Copy link

a-m-s commented Nov 10, 2020

Now fixed.

@a-m-s a-m-s closed this as completed Nov 10, 2020
@jiri-janousek
Copy link
Member

Please keep the issue open until a Flatpak package with the fix is released to avoid bug duplicates.

@jiri-janousek jiri-janousek reopened this Nov 10, 2020
@jiri-janousek
Copy link
Member

Rebuilt flatpak has been published - script version 5.10.2 (2-g2a707a9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is not working as expected or the documentation is incorrect.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants