[BUG] On Windows, file handles are opened with no FILE_SHARE_* mode, preventing other software (e.g. extensions) from opening those files

[BinToss]

I've been frequently noticing dotnet build and similar operations complaining about "access denied" and "The process cannot access the file .../obj/project.assets.json because it is being used by another process."

Searching for handles with System Informer results in the relevant files only being opened by the dotnet.exe process hosting this extension.

[tintoy]

That’s odd; I thought we didn’t keep that file open for any real length of time but I’ll see if we can explicitly specify the sharing flags anyway.

Thanks for reporting!

[tintoy]

Oops! As it turns out, we completely forget to close that file handle until the stream gets garbage-collected:

msbuild-project-tools-server/src/LanguageServer.Common/Utilities/MSBuildHelper.cs

Line 408 in a01749a

rootNode = JsonNode.Parse(projectAssetsFile.OpenRead());

I’ll sort that out sometime today 🙂

[tintoy]

Transferring this issue to the language server repository.

[tintoy]

We’ll get a new package published today or tomorrow 🙂

[tintoy]

Published v0.5.3 to the VS extension gallery (it may take a couple of minutes to be come visible) 🙂