Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ... from handling re-broken in the revert? #174

Closed
pglewis opened this issue May 15, 2017 · 8 comments
Closed

export ... from handling re-broken in the revert? #174

pglewis opened this issue May 15, 2017 · 8 comments

Comments

@pglewis
Copy link

pglewis commented May 15, 2017

#128 was fixed but I believe export ... from support was broken again with the revert, from trying to follow the history bread-crumbs.

@pglewis pglewis changed the title Export handling re-broken in the revert? export ... from handling re-broken in the revert? May 15, 2017
@fatfisz
Copy link
Contributor

fatfisz commented May 15, 2017

Hi @pglewis, could you please provide more details? The tests indicate otherwise, so we need more info.

Your plugin version and configuration, example code and output from the console (if there are any errors) would be a nice start. A proof of concept repo would be even more appreciated.

@pglewis
Copy link
Author

pglewis commented May 15, 2017

2.7.0:

https://github.com/tleunen/babel-plugin-module-resolver/blob/v2.7.0/src/index.js#L82-L85

Note the missingExportDeclaration block

@pglewis
Copy link
Author

pglewis commented May 15, 2017

A vanilla "npm install babel-plugin-module-resolver -D" will currently install 2.7. I can copy the missing ExportDeclaration block into my local node_modules copy and my build does work properly.

It appears 3.0 beta may handle export ... from again, but 3.0 beta errors for me.

2.6.2 has the original commit and export ... from works, however it does not work with another plugin, transform-html-import-to-string (imports our HTML/underscore templates as JS strings via normal import).

So a locally modified 2.7 is the only thing that works for me, which isn't something I can cleanly carry over to TravisCI.

@pglewis
Copy link
Author

pglewis commented May 15, 2017

What would be perfect from my side would be a NPM 2.7.1 release based off the 2.7.0 tag and including the ExportDeclaration block (and associate tests) from 627b897. It appears that would work perfectly for me and would automatically work on TravisCI.

@tleunen
Copy link
Owner

tleunen commented May 15, 2017

Could you also report the error you have with 3.0 beta? Our goal is to make 3.0 stable and release it for good.

@pglewis
Copy link
Author

pglewis commented May 15, 2017

Will do, my changes for testing this are currently stashed since I'm bouncing in about 5 directions. I'll pull that up again today and gather the error. [also, I should know better than to mix issues on one ticket. New issue created]

@fatfisz
Copy link
Contributor

fatfisz commented May 15, 2017

Thanks @pglewis, you really did a great job at providing all this info! Also a lesson for me to check the history properly next time.

I'll get to fixing #175 ASAP so that you can use the beta version.

@pglewis
Copy link
Author

pglewis commented May 16, 2017

3.0 does support export ... from. My issues with 3.0 beta appear to have been version/dependency related.

@pglewis pglewis closed this as completed May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants