Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3.php is huge and is becoming unmanageable :( #162

Open
codemedic opened this issue Oct 4, 2019 · 0 comments
Open

S3.php is huge and is becoming unmanageable :( #162

codemedic opened this issue Oct 4, 2019 · 0 comments

Comments

@codemedic
Copy link

Would it be acceptable to split S3.php such that the client code only still need to include the one S3.php (for those no-composer situations)?

What I am suggesting is to split classes into their own files (ClassName.php) and S3.php would always require_once these files. A bit clunky, but makes it easier to maintain the code.

Given a choice I would prefer to PSR-4 -ise it with namespaces etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant