Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

droetker.com.tr: cookie notice #15446

Closed
5 of 9 tasks
ghost opened this issue Oct 28, 2022 · 13 comments
Closed
5 of 9 tasks

droetker.com.tr: cookie notice #15446

ghost opened this issue Oct 28, 2022 · 13 comments

Comments

@ghost
Copy link

ghost commented Oct 28, 2022

Prerequisites

  • I read and understood the policy as to what is a valid filter issue
  • I verified that the issue has not already been reported (use this button to find out)
  • I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
  • I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
  • I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
  • I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
  • I am not using another content blocker along uBO
  • I verified the issue is not caused by the browser built-in blocker, or DNS blocking (standalone or through VPN)
  • I did not answer truthfully to all the above checkpoints

URL address of the web page

https://www.droetker.com.tr/index

Category

breakage

Describe the issue

Enable AdGuard Annoyances filter and check all Dr. Oetker websites.
The oetker.*/static/js/privacy-dialog/ script is filtered by uBO on the following websites and will also appear in the filtering log.

https://www.oetker.at/at-de/index
https://www.oetker.be/be-nl/index
https://www.oetker.hr/hr-hr/index
https://www.oetker.com.br/index
https://www.oetker.bg/bg-bg/index
https://www.oetker.ca/ca-en/index
https://www.oetker.hr/hr-hr/index
https://www.oetker.cz/cz-cs/index
https://www.oetker.dk/dk-da/index
https://www.oetker.fi/
https://www.oetker.fr/fr-fr/index
https://www.oetker.de/index
https://www.oetker.gr/gr-el/index
https://www.oetker.hu/hu-hu/index
https://www.oetker.in/in-en/index
https://www.oetker.ie/ie-en/index
https://www.oetker.lt/lt-lt/index
https://www.oetker.com.my/my-en/index
https://www.oetker.com.au/au-en/index
https://www.oetker.no/no-no/index
https://www.oetker.pl/pl-pl/index
https://www.oetker.pt/pt-pt/index
https://www.oetker.ro/ro-ro/homepage
https://www.oetker.se/se-sv/index
https://www.oetker.ch/ch-de/index
https://www.oetker.rs/rs-sr/index
https://www.oetker.sk/sk-sk/index
https://www.oetker.si/si-si/index
https://www.oetker.es/es-es/index
https://www.oetker.co.za/za-en/index
https://www.oetker.nl/nl-nl/index
https://www.droetker.com.tr/index
https://www.oetker.co.uk/
https://www.oetker.us/us-en/index

However, script is not filtered on the https://www.droetker.com.tr/index website and does not appear in the log.

The problem can also be reproduced with the default filters. It looks like the uBO issue.

Screenshot(s)

https://www.oetker.ca/ca-en/index

Screenshot(s)

resim


Firefox browser
the script is not filtered.
https://www.droetker.com.tr/index

Screenshot(s)

resim


Chrome browser
The oetker.*/static/js/privacy-dialog/ script does not appear in the uBO filtering log.

Screenshot(s)

resim

Configuration

uBlock Origin: 1.44.4
Firefox: 106
filterset (summary): 
  network: 116599
  cosmetic: 148776
  scriptlet: 34258
  html: 793
listset (total-discarded, last updated): 
  removed: 
    urlhaus-1: null
    plowe-0: null
  added: 
    adguard-generic: 64476-4643, 1d.1h.4m
    adguard-spyware: 35853-2791, 1d.1h.4m
    adguard-spyware-url: 793-3, 1d.1h.4m
    adguard-annoyance: 60231-1531, 1d.1h.4m
    adguard-social: 18682-34, 1d.1h.4m
  default: 
    user-filters: 67-0, never
    ublock-filters: 33015-32, 1d.1h.5m
    ublock-badware: 4356-0, 1d.1h.5m
    ublock-privacy: 288-0, 1d.1h.5m
    ublock-abuse: 76-0, 1d.1h.5m
    ublock-unbreak: 1885-1, 1d.1h.5m
    ublock-quick-fixes: 429-21, 7m
    easylist: 62370-943, 1d.1h.4m
    easyprivacy: 30818-13972, 1d.1h.4m
    TUR-0: 11205-19, 1d.1h.4m
filterset (user): [array of 71 redacted]
trustedset: 
  added: [array of 1 redacted]
modifiedUserSettings: 
  contextMenuEnabled: false
  prefetchingDisabled: false
  showIconBadge: false
  suspendUntilListsAreLoaded: false
  tooltipsDisabled: true
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 3470 ms (selfie)
  maxAssetCacheWait: 980 ms
  unsuspendAfter: 2454 ms
popupPanel: 
  blocked: 5
  blockedDetails: 
    droetker.com.tr: 4
    googletagmanager.com: 1
@okiehsch
Copy link
Contributor

okiehsch commented Oct 28, 2022

image

It does appear but only on the first load, after that you have to load the site bypassing the cache for it to reappear.

@okiehsch
Copy link
Contributor

okiehsch commented Oct 28, 2022

However, script is not filtered on the https://www.droetker.com.tr/index website and does not appear in the log.

Why should the script be filtered on this website?

@ghost
Copy link
Author

ghost commented Oct 28, 2022

However, script is not filtered on the https://www.droetker.com.tr/index website and does not appear in the log.

Why should the script be filtered on this website?

Blocking this script hides the cookie notification. I'm seeing a cookie notice because it's not filtered.

Image

resim

@okiehsch
Copy link
Contributor

Well, yes but what I meant is why should the filter
oetker.*/static/js/privacy-dialog/
block anything on the site
droetker.com.tr

I can reproduce the cookie notification but if you want to block it you need the filter
droetker.*/static/js/privacy-dialog/

@MasterKia MasterKia changed the title droetker.com.tr: breakage droetker.com.tr: cookie notice Oct 28, 2022
@krystian3w
Copy link
Contributor

Maybe regression in enforce network filtering - maybe few pages still don't added prefix dr in domain.

to test possible use $important

oetker.*/static/js/privacy-dialog/$important

krystian3w referenced this issue in FiltersHeroes/PolishSocialCookiesFiltersDev Oct 28, 2022
za pomysłem alex-302

Co-Authored-By: Alex <[email protected]>
Co-Authored-By: Adam <[email protected]>
@okiehsch
Copy link
Contributor

That does not work.
So you mean
oetker.*/static/js/privacy-dialog/
does work on droetker.com.tr using Adguard?

krystian3w referenced this issue in AdguardTeam/AdguardFilters Oct 28, 2022
@ghost
Copy link
Author

ghost commented Oct 28, 2022

That does not work. So you mean oetker.*/static/js/privacy-dialog/ does work on droetker.com.tr using Adguard?

Yes it works using AdGuard.

Image

resim

@krystian3w
Copy link
Contributor

krystian3w commented Oct 28, 2022

Maybe cname glitch or tokenizing domain.

It works for me in regex syntax:

/oetker\..*\/static\/js\/privacy-dialog\//

@okiehsch
Copy link
Contributor

okiehsch commented Oct 28, 2022

Ok. it is a quite unusual filter and I thought it would be treated like
||oetker.*/static/js/privacy-dialog which is the reason that I was not surprised that it was not blocked by uBO.

I opened an internal issue about it.

@okiehsch
Copy link
Contributor

okiehsch commented Oct 28, 2022

Answer by gorhill:
"That is another difference with AdGuard and ABP....
in uBO I considered that not assuming word boundary at the start of a filter is technical debt from early ABP era and I did away with this in uBO -- word boundary is always assumed at the start in uBO. This did not cause widespread breakage because that kind of filter is extremely rare in filter lists -- and the benefit was efficient matching algorithm implementation.

I wish AdGuard adopted the same approach, and really all blockers could switch to the uBO approach without much breakage, except for that one filter you found today. In uBO, that filter would be:

*oetker.*/static/js/privacy-dialog
To make non word-boundary an explicit choice by the filter author."

@okiehsch
Copy link
Contributor

The issue was first discussed at gorhill/uBlock#1065

@Yuki2718
Copy link
Contributor

This is also mentioned in our wiki: https://github.com/gorhill/uBlock/wiki/Syntax-quirks

@okiehsch
Copy link
Contributor

I will add
||droetker.*/static/js/privacy-dialog/
to our annoyance list, to deal with this unique case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants