Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movieweb.com: nuisance #20490

Closed
9 of 10 tasks
superlex opened this issue Nov 6, 2023 · 9 comments
Closed
9 of 10 tasks

movieweb.com: nuisance #20490

superlex opened this issue Nov 6, 2023 · 9 comments

Comments

@superlex
Copy link
Contributor

superlex commented Nov 6, 2023

Prerequisites

  • This is NOT a YouTube, Facebook or Twitch report.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Search here to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other content blocker extensions.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL(s) where the issue occurs.

https://movieweb.com/biggest-kaiju-movie-monsters/

Description

subscription request

AG fixed it with $cookie modifier, is there an other way since uB0 doesn't support it?
AdguardTeam/AdguardFilters@236ee4d

Other extensions used

none

Screenshot(s)

dd

Configuration

Details
default filters lists
@gorhill
Copy link
Member

gorhill commented Nov 6, 2023

Unable to reproduce using default settings/lists.

You will have to investigate this yourself given you are not providing troubleshooting information.

@mapx-
Copy link
Contributor

mapx- commented Nov 6, 2023

@superlex you linked filters for other pages ?!
xda-developers.com|androidpolice.com

@gorhill
Copy link
Member

gorhill commented Nov 6, 2023

AG fixed it with $cookie modifier,

You link to a commit that doesn't make use of #cookie modifier, it's the remove-cookie scriptlet, which is supported in uBO.

Anyway, closing this as this is an unactionable report, the troubleshooting information should always be provided, not removed, otherwise it's for OP to investigate on their side.

@gorhill gorhill closed this as completed Nov 6, 2023
@gorhill gorhill added the invalid label Nov 6, 2023
@superlex
Copy link
Contributor Author

superlex commented Nov 6, 2023

@mapx-
yes, because the issue (and the fix) was the same.

@gorhill
I can no longer replicate it in any of three sites, sorry.
Btw, AG make use of both #cookie modifier and remove-cookie scriptlet, the first one to prevent the cookie form being set, the second one to remove it (but it works only if you reload the page).
In other words, after you scrolled some articles:

  • using only the scriptlet you get the subscription request, but it's removed after you reload the page;
  • using the $cookie modifier you don't get the subscription request at all.

Anyway, closing this as this is an unactionable report, the troubleshooting information should always be provided, not removed, otherwise it's for OP to investigate on their side.

You're right, sorry.

@gorhill
Copy link
Member

gorhill commented Nov 6, 2023

After navigating to how many articles is the overlay supposed to appear?

I see a cookie named unauthenicatedArticleLimitReached with value false in dev tools.


The code that make use of that cookie is in https://movieweb.com/public/build/valnet-footer-article.db7311a2.js

@superlex
Copy link
Contributor Author

superlex commented Nov 6, 2023

After navigating to how many articles is the overlay supposed to appear?

After 5/6 articles.

I see a cookie named unauthenicatedArticleLimitReached with value false in dev tools.

Yes, and after you reached the limit it's set to true.

The code that make use of that cookie is in https://movieweb.com/public/build/valnet-footer-article.db7311a2.js

You're right, infact the only way I found to remove the overlay was preventing trackUnauthenticatedArticleViews(), but it still wouldn't let you continue reading.

@stephenhawk8054
Copy link
Member

Which country are you when accessing the site?

@superlex
Copy link
Contributor Author

superlex commented Nov 7, 2023

@stephenhawk8054

Italy.
Do you think it could depend on this?

@superlex
Copy link
Contributor Author

superlex commented Nov 11, 2023

@mapx-

Fixed here for xda-developers.com|androidpolice.com
#20059
Simply add movieweb.com too:
fd92945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants