Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

728x90.jpg| - the rule doesn't work #8548

Closed
5 of 8 tasks
ghost opened this issue Feb 8, 2021 · 8 comments
Closed
5 of 8 tasks

728x90.jpg| - the rule doesn't work #8548

ghost opened this issue Feb 8, 2021 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 8, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

728x90.jpg| ~> EasyList - doesn't work in uBO, but works in ABP.

A specific URL where the issue occurs

http://progolovne.ck.ua/

Steps to Reproduce

  1. Go to http://progolovne.ck.ua/
  2. [Second Step]
  3. [and so on...]

Expected behavior:

Hiding an element

Screen - uBO

7yPv1o

Screen - ABP

2021-02-08_140217

Actual behavior:

Element is not hidden

Screen

7yPv1z
7yPv1A

Your environment

  • uBlock Origin version: 1.33.2
  • Browser Name and version: Google Chrome ( 88.0.4324.150)
  • Operating System and version: Windows 8.1x64
@uBlock-user
Copy link
Contributor

By design, *728x90.jpg| will work. This was discussed in some issue before.

@uBlock-user
Copy link
Contributor

See -- gorhill/uBlock#1065

@ghost
Copy link
Author

ghost commented Feb 8, 2021

All such rules from EasyList will not work?

@gorhill
Copy link
Member

gorhill commented Feb 8, 2021

A rule such as 728x90.jpg| will also block a request which URL ends with 1728x90.jpg in ABP, while this is clearly not the intent of the filter. For example such false positive was reported here.

In uBO, a non-word boundary at the start of a pattern must be explicit when a pattern starts with a letter/digit, and this is how ABP should have been designed originally, I consider this technical debt which I won't make part of uBO, it is an impediment to memory- and CPU-efficient content blockers.

All in all, as a result I consider the chance of false negative to balance out the chance of false positive, i.e. both are rare and if I am going to pick one over the other, I pick the one which does not prevent efficiency. The solution is to report the issue to filter list maintainers, this will be addressed in uBO's own filter lists.

Such instance are extremely rare, so it's not something to worry about -- you can consider that EasyList is pretty much always properly enforced.

@gorhill gorhill closed this as completed Feb 8, 2021
@gorhill gorhill reopened this Feb 8, 2021
@gorhill gorhill transferred this issue from uBlockOrigin/uBlock-issues Feb 8, 2021
@gorhill
Copy link
Member

gorhill commented Feb 8, 2021

I transferred here because we should add -ad728x90.?

@gorhill
Copy link
Member

gorhill commented Feb 8, 2021

cc @dimisa-RUAdList

@uBlock-user
Copy link
Contributor

It's a telegram group link of that website. not an ad. Should we still block it ?

@dimisa-RUAdList
Copy link

No, you don't need to add anything. Specifically this problem was solved here: easylist/ruadlist@ba2a92e#diff-f755aab522aa5f7274e4a9cae748b359c0910553178eb3d00504408c376ad826R1116

In general, the point was that some of the rules really do not work. But in most cases, I fix this with additional rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants