-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with Wikiwand on Firefox #158
Comments
What are the steps to reproduce the issue? |
I have the latest versions of both extensions installed on Firefox 128.0.2, Windows 11 x64 (MSIX), with what I think is default settings (except for using Optimal instead of Basic filtering mode) To reproduce the issue i simply search for anything that shows results from Wikipedia, and click on one of the results from wikipedia.org With only Wikiwand installed, I'm automatically redirected to the Wikiwand equivalent of the same article, but with uBOL enabled with |
Are you sure, because I'm unable to reproduce on Basic, I can reproduce only on "Optimal" or "Complete". Also the issue is gone after disabling:
|
The issue doesn't exist for Chromium, it affects only Firefox. The issue exists when using either Optimal or Complete mode as the default one, and doesn't exists when using Basic mode as the default one. Modifying the per-site mode makes no difference. The issue arises because of the DNR rule to remove query parameters: That DNR rule is the result of grouping privacy-related filters such as The rule's condition is Firefox's assessment that a DNR rule match occurs causes it to skip passing the request to The issue doesn't exist when default mode is Basic because in such case the The fact that the issue doesn't exist in Chromium suggests that maybe the DNR code in Firefox needs to be adjusted. Regarding uBOL, a solution would be to not coalesce the over 100 uBO's own filtering engine does optimize to efficiently store filters such as |
It turns out I had switched the filtering mode to Basic only for the search engine, which didn't get saved as per-site overrides are only available for completely disabling filtering I had the global filtering mode set to Optimal, and the only enabled filter list was "Ads, trackers, miners, and more" |
Per-site overrides are available for all filtering modes. |
Wait, they are? Also, apologies for not doing more research before writing lol |
They are not listed, the popup panel will reflect whichever mode has been last selected for the current site. |
Using uBOL with
BasicOptimal or higher filtering mode prevents the Wikiwand extension from redirecting links going to wikipedia.orgThe text was updated successfully, but these errors were encountered: