-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove-class "stay" doesn't prevent re-injection #2203
Comments
File.io no longer host demo/image/video (GitHub like MP4 with any codecs). Form Polish demo you can also try kill pop-up to select radio station by Also in the past I found war with re-add class/attributes so page blink/jumps as long to delete filter. |
#2667 - strona brzydko przywraca tag style, potrzebujemy lepszy skryptlet lub konserwacja tych dwóch. Opcjonalnie bug w uBo z wykrywaniem zmian w drzewie dom/nodzie.
Video does not exists. I cannot find |
For example look for
Same result. |
Can you check how works this in AdGuard, his scriptlet support loop/MutationObserver without parameters. |
Video added. |
@krystian3w I tested that filter in AdGuard on Ungoogled Chrmoium, same behavior as the video. The only difference I noticed is that AdGuard seems to prevent the re-injection for a few seconds. |
So also no implemented abort injection correct. |
There is no feature to prevent reinjection. You will need to find the code responsible for this and block it some other way. |
The site (used to?) have ad re-insertion.
|
Any help is appreciated. |
I'm talking about the |
What's the fundamental back-end difference between Because |
It's just coincidence. Probably, page script fails when it cannot find the element on which it want to work. |
Whatever piles of code I would throw at uBO (while having to keep maintaining it forever) would be pointless given that the site you are giving as an example is bent on working around whatever uBO does. So I prefer to decline given that the feature is meant to address one specific anti-blocker feature at that one specific site; all work which would become pointless as soon as the site works around it. |
Prerequisites
I tried to reproduce the issue when...
Description
Maybe related: #1445
A specific URL where the issue occurs
soft98.ir
Steps to Reproduce
0- Preferably disable uBO Quick-Fixes to prevent interference
1- Go to
soft98.ir
2- Open inspect element
3- Add
soft98.ir##+js(rc, clean, *, stay)
to My filters.4- Refresh the page.
5- The "clean" class gets removed by uBO but is instantly injected again by site.
Expected behavior
uBO should abort attempts to re-inject classes.
Also it's preferable if uBO could pretend that the re-injection was successful.
Actual behavior
If the site can re-inject classes then the purpose of remove-class "stay" is defeated entirely.
See:
remove-class.mp4
uBlock Origin version
1.43.0
Browser name and version
Firefox 103.0.1
Operating System and version
Fedora 36 KDE
The text was updated successfully, but these errors were encountered: