-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdGuard divvied up annoyance filters #2217
Comments
Maybe possible add margin-left (or "margin-start" https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-start) for list embedded in bigger: (Draft with MD check list)
(Fanboy's don't create file without Cookies and Social - uBo mirror added support for split) I think margin need update logic or CSS so need uBo 1.44.1+ to avoid use second level of collapsing list with undocumented scenario. |
The nested list suggestion is interesting. Would selecting the parent automatically disable/gray-out its children? (or perhaps that's too much hand-holding and there's value in being able to select them both for debugging something?) |
Latest uBo generate classes "checked", so this can be used to disable click on smaller part of list (and stylize input) by only CSS, but don't generate pop-up with information for newbies why selection are disabled (this works better after use JS). [I don't checked unsupported version older than uBO legacy - these may don't generate "checked" class - if still support remote update assets]. But idea can by dropped due uBo ignore duplicates. At this time I cannot estimate how much time and effort one or both activities will take for gorhill or contributors after green light to wirte these by other people and check quality of solution. Later all issue can be closed due nobody need smaller versions and no have real reason to delete AG in favor Fanboy's. |
Wasn't this declined few days ago? Déjà vu? |
I couldn't find anything related to this when I searched the issues, but it's possible I missed it! |
On Reddit? We don't have access to slack and uBlock-volunteer team.
IMO not on GitHub, prerequisites no talking to research on Reddit or hack hidden places. |
I proposed the same on internal discussion https://github.com/orgs/uBlockOrigin/teams/ublock-filters-volunteers/discussions/421 but not declined. |
So maybe missed as weird. |
As public possible read opinion about consideration disable joining files into big one: AdguardTeam/FiltersRegistry#718 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Fanboy added a new Agegate List. |
Prerequisites
I tried to reproduce the issue when...
Description
AdGuard recently divvied up their Annoyances list into five new lists:
Would it make sense to include these in uBlock Origin in the same way that EasyList Cookie and Fanboy's Social are included alongside Fanboy's Annoyance?
A specific URL where the issue occurs
https://adguard.com/en/blog/new-annoyance-filters.html
Steps to Reproduce
N/A
Expected behavior
Here's what it could look like in
assets.json
:assets.json
Actual behavior
N/A
uBlock Origin version
1.43
Browser name and version
Firefox 103
Operating System and version
Windows 10
The text was updated successfully, but these errors were encountered: