Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuard divvied up annoyance filters #2217

Closed
8 tasks done
wavygecko opened this issue Aug 17, 2022 · 12 comments
Closed
8 tasks done

AdGuard divvied up annoyance filters #2217

wavygecko opened this issue Aug 17, 2022 · 12 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@wavygecko
Copy link

wavygecko commented Aug 17, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

AdGuard recently divvied up their Annoyances list into five new lists:

  1. Cookie Notices — blocks cookie notices on web pages
  2. Popups — blocks all kinds of pop-ups that are not necessary for websites' operation
  3. Mobile App Banners — blocks banners that promote mobile apps of websites
  4. Widgets — blocks third-party widgets: online assistants, live support chats, etc.
  5. Other Annoyances — blocks elements that do not fall under the popular categories of annoyances

Would it make sense to include these in uBlock Origin in the same way that EasyList Cookie and Fanboy's Social are included alongside Fanboy's Annoyance?

A specific URL where the issue occurs

https://adguard.com/en/blog/new-annoyance-filters.html

Steps to Reproduce

N/A

Expected behavior

Here's what it could look like in assets.json:

assets.json
	"adguard-cookie-notices": {
		"content": "filters",
		"group": "social",
		"off": true,
		"title": "AdGuard Cookie Notices",
		"contentURL": "https://filters.adtidy.org/extension/ublock/filters/18.txt",
		"supportURL": "https://github.com/AdguardTeam/AdguardFilters#adguard-filters",
		"instructionURL": "https://kb.adguard.com/en/general/adguard-ad-filters"
	},
	"adguard-popups": {
		"content": "filters",
		"group": "social",
		"off": true,
		"title": "AdGuard Popups",
		"contentURL": "https://filters.adtidy.org/extension/ublock/filters/19.txt",
		"supportURL": "https://github.com/AdguardTeam/AdguardFilters#adguard-filters",
		"instructionURL": "https://kb.adguard.com/en/general/adguard-ad-filters"
	},
	"adguard-mobile-app-banners": {
		"content": "filters",
		"group": "social",
		"off": true,
		"title": "AdGuard Mobile App Banners",
		"contentURL": "https://filters.adtidy.org/extension/ublock/filters/20.txt",
		"supportURL": "https://github.com/AdguardTeam/AdguardFilters#adguard-filters",
		"instructionURL": "https://kb.adguard.com/en/general/adguard-ad-filters"
	},
	"adguard-widgets": {
		"content": "filters",
		"group": "social",
		"off": true,
		"title": "AdGuard Widgets",
		"contentURL": "https://filters.adtidy.org/extension/ublock/filters/22.txt",
		"supportURL": "https://github.com/AdguardTeam/AdguardFilters#adguard-filters",
		"instructionURL": "https://kb.adguard.com/en/general/adguard-ad-filters"
	},
	"adguard-other-annoyances": {
		"content": "filters",
		"group": "social",
		"off": true,
		"title": "AdGuard Other Annoyances",
		"contentURL": "https://filters.adtidy.org/extension/ublock/filters/21.txt",
		"supportURL": "https://github.com/AdguardTeam/AdguardFilters#adguard-filters",
		"instructionURL": "https://kb.adguard.com/en/general/adguard-ad-filters"
	},

Actual behavior

N/A

uBlock Origin version

1.43

Browser name and version

Firefox 103

Operating System and version

Windows 10

@krystian3w
Copy link

krystian3w commented Aug 18, 2022

Maybe possible add margin-left (or "margin-start" https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-start) for list embedded in bigger:

(Draft with MD check list)

  • AG Annoyances
    • Cookie Notices
    • Popups
    • Mobile app banners
    • Widgets
    • Others Annoyances (undefined in other categories)
  • Fanboy Annoyances
    • Fanboy Social
    • Easylist Cookies

(Fanboy's don't create file without Cookies and Social - uBo mirror added support for split)

I think margin need update logic or CSS so need uBo 1.44.1+ to avoid use second level of collapsing list with undocumented scenario.

@wavygecko
Copy link
Author

wavygecko commented Aug 18, 2022

The nested list suggestion is interesting. Would selecting the parent automatically disable/gray-out its children? (or perhaps that's too much hand-holding and there's value in being able to select them both for debugging something?)

@krystian3w
Copy link

krystian3w commented Aug 18, 2022

Latest uBo generate classes "checked", so this can be used to disable click on smaller part of list (and stylize input) by only CSS, but don't generate pop-up with information for newbies why selection are disabled (this works better after use JS).

[I don't checked unsupported version older than uBO legacy - these may don't generate "checked" class - if still support remote update assets].

But idea can by dropped due uBo ignore duplicates.

At this time I cannot estimate how much time and effort one or both activities will take for gorhill or contributors after green light to wirte these by other people and check quality of solution.

Later all issue can be closed due nobody need smaller versions and no have real reason to delete AG in favor Fanboy's.

@gwarser
Copy link

gwarser commented Aug 18, 2022

Wasn't this declined few days ago? Déjà vu?

@wavygecko
Copy link
Author

I couldn't find anything related to this when I searched the issues, but it's possible I missed it!

@krystian3w
Copy link

krystian3w commented Aug 18, 2022

Wasn't this declined few days ago? Déjà vu?

On Reddit? We don't have access to slack and uBlock-volunteer team.

possible I missed it!

IMO not on GitHub, prerequisites no talking to research on Reddit or hack hidden places.

@Yuki2718
Copy link

I proposed the same on internal discussion https://github.com/orgs/uBlockOrigin/teams/ublock-filters-volunteers/discussions/421 but not declined.

@krystian3w
Copy link

So maybe missed as weird.

@krystian3w
Copy link

As public possible read opinion about consideration disable joining files into big one: AdguardTeam/FiltersRegistry#718

@uBlock-user
Copy link
Contributor

uBlock-user commented May 17, 2023

addressed in dev build.
Capture

@uBlock-user uBlock-user added enhancement New feature or request fixed issue has been addressed labels May 17, 2023
@krystian3w

This comment was marked as off-topic.

@Yuki2718
Copy link

Yuki2718 commented Jan 3, 2024

Fanboy added a new Agegate List.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

5 participants