-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network unavailable may cause filter become "0 used out of 0" #30
Comments
Waited 5 mins, no change. Can't reproduce on Firefox 59 |
I did more tests. this problem only occurs in private browsing mode (browser.privatebrowsing.autostart=true) |
uBO does not save filter lists in window.localStorage. I first want to investigate to find out what is the real issue. A filter list should never be empty, uBO has code to avoid trashing the cache when the returned response is empty. |
Hmmm, so it's not related to the FF bug ? |
This is how it looks like if I reproduce it on Nightly - |
Only private browsing mode is needed to reproduce? |
I can't reproduce: I enabled private browsing mode, and all the filter lists which are fetched from a remote server are properly fetched. |
No, not just that, you need to setup a proxy in Firefox, with an invalid server address like 0.0.0.0 like it's mentioned in the STR. |
I am going to need exact, detailed steps for this. |
|
I can't reproduce with that proxy config. However I can reproduce if I disable my access to internet -- something which is not described anywhere in the repro steps. Also, something is wrong in OP's report, or I still just can't reproduce as described. The only way I can get "0 out of 0" is if I try to fetch the remote filter list when it is not yet present in the cache -- and in such case, it is indeed expected, as per https://bugzilla.mozilla.org/show_bug.cgi?id=1313401. Thus marking as unable to reproduce as per OP's repro steps. |
If you set your proxy address to 0.0.0.0, then you're basically cutting off Firefox's access to the Internet. you won't be able to open any websites at all. |
My internet access was not cut off, which means Firefox was somehow ignoring the proxy and connecting using an available connection (using linux here). |
Yes I get that page. I also get successful network requests by Firefox itself and uBO: It could be because on FF59/linux extensions are not yet in their own content process, and maybe FF main process does not go through the designated proxy. In any case, just turning off the connection should accomplish the same thing. However at this point, issue should be closed assuming OP reported wrongly -- can't never emphasize enough "exact and detailed". uBO does not overwrite the cache with empty content. The only way to get "0 out of 0" is if the cache was empty in the first place -- and no cache are removed when clicking "Purge all caches". |
To me it seems more and more of a browser bug if any. |
When a filter list is not in the cache and there is no connection available, there is no way for uBO to download the list, hence "0 out of 0" -- you will get the same issue with any browser. If you want to assume OP described the issue improperly (likely) and that is issue is that uBO loses the cached lists upon browser restart because of private browsing mode, then yes, it is a known Firefox bug. |
Sorry, now I understand that this is a bug of the Firefox's private browsing mode. About invalid proxy settings with "0 out of 0":
|
Prerequisites
Description
(Sorry, my English is very poor)
I use a socks5 proxy server to connect to the network, sometimes the proxy server may not be available,
if uBlock try to update filter lists at this time, some filter may will become "0 used out of 0"
A specific URL where the issue occurs
[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]
Steps to Reproduce
Expected behavior:
[What you expected to happen]
Actual behavior:
[What actually happened]
Your environment
The text was updated successfully, but these errors were encountered: