Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the use of ubulk and uouttot #54

Open
bss116 opened this issue Dec 20, 2019 · 1 comment
Open

Check the use of ubulk and uouttot #54

bss116 opened this issue Dec 20, 2019 · 1 comment
Assignees
@madDipanjan
Labels
clean-up fortran invalid This doesn't seem right
Milestone
1.1.0

Comments

@bss116
Copy link
Contributor

bss116 commented Dec 20, 2019

The use of the variables ubulk and uouttot are currently a bit confusing.
The variable uouttot is calculated in the flow rate forcing and then (always? only with some switches?) overwritten and used by modboundary. It needs to be checked that this is done correctly and as intended.
The calculation in modstartup and use of the variable ubulk in modboundary should also be checked. ubulk is the volume averaged velocity (e.g. 2 m/s), and uouttot as calculated in the flow rate forcing masscorr is the outlet plane averaged velocity times the outlet area.
@bss116 bss116 added invalid This doesn't seem right clean-up labels Dec 20, 2019
@bss116 bss116 added this to the 0.2.0 milestone Jan 16, 2020
This was referenced Apr 3, 2020
Open
Merged
@tomgrylls
Copy link
Contributor

Pending #70, I have a few ideas for this. Also in line with #68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madDipanjan madDipanjan

Labels
clean-up fortran invalid This doesn't seem right
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@bss116 @tomgrylls @samoliverowens @madDipanjan