Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for some indication for not using dynamics equation when using TimeDriver() #143

Open
kzqureshi opened this issue Jul 28, 2023 · 3 comments
Assignees

Comments

@kzqureshi
Copy link
Contributor

The simulation "runs" but nothing happens.

@swapneelap
Copy link
Member

swapneelap commented Jul 28, 2023

Do I understand correctly that you want to raise an error/warning when one runs a TimeDriver in the absence of system.dynamics term(s)?

Also, what exactly do you mean by "nothing happens"? Do you mean that system.m does not update or the simulation continues endlessly?

@kzqureshi
Copy link
Contributor Author

Do I understand correctly that you want to raise an error/warning when one runs a TimeDriver in the absence of system.dynamics term(s)?
Yes, you understand correctly
Also, what exactly do you mean by "nothing happens"? Do you mean that system.m does not update or the simulation continues endlessly?
system.m does run but the inital state does not change after TimeDriver as system.dynamics were not mentioned.

@swapneelap
Copy link
Member

Okay I understand. I have three questions:

  1. Should we raise an error/warning if OOMMF is OK with running a time driver with no dynamics term?
  2. I am leaning towards raising a warning. I think raising an error would be too strong a stance. Does this sound reasonable?
  3. If we implement this in oommfc, it would good to know what mumax3 does in such a situation and maybe raise an error/warning in mumax3c as well for consistency. Does this sound reasonable?

It would be good to know @lang-m, @samjrholt, @fangohr opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants