Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spellchecking into fmt #47

Open
KaiserKarel opened this issue May 19, 2023 · 1 comment
Open

Move spellchecking into fmt #47

KaiserKarel opened this issue May 19, 2023 · 1 comment
Labels
A-ci Area: Our CI A-nix Area: Our Nix configuration C-dx Category: Developer Experience S-shelved Status: Not actively being worked on, PR/issue still open for reference

Comments

@KaiserKarel
Copy link
Contributor

We currently do loads of fixup commits in PRs because of spelling errors due to two reasons:

  • nix fmt is great, but misses out on spellchecking. nix build ./#checks.{system}.spellcheck is verbose.
  • cspell isn't great at checking rust and golang code, and errors on variable names, function names etc. Ideally we would ignore code and only check doc comments.

It'd be nice if tree-fmt supported spellchecking, and more specifically would set regexes per language to ensure we only check what we care about.

@KaiserKarel KaiserKarel added C-dx Category: Developer Experience A-ci Area: Our CI A-nix Area: Our Nix configuration labels May 19, 2023
@KaiserKarel
Copy link
Contributor Author

Tracking adding support for cspell to tree-fmt here

@KaiserKarel KaiserKarel changed the title Move spellchecking into linting Move spellchecking into fmt Jun 7, 2023
@PoisonPhang PoisonPhang added the S-shelved Status: Not actively being worked on, PR/issue still open for reference label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Our CI A-nix Area: Our Nix configuration C-dx Category: Developer Experience S-shelved Status: Not actively being worked on, PR/issue still open for reference
Projects
None yet
Development

No branches or pull requests

2 participants