IVIM dependencies seem off (original ETSI source)

[MrMushroom]

Issue

This is only an observation. No issue has been detected yet.

./command.sh uses a file as dependency that is not loaded. Instead of loading the file, another file is checked twice.

This is also the case with original ETSI sources

Setup

Not necessary, it is in the source files.

Problem Description

Copied mistake from original sources in syntax_check.bash from ETSI forge

This Repo

One file is loaded twice.

  if [ ! -f "$ETSI_ITS_BUILD_ROOT_DIR"/asn1/"ISO14906(2018)EfcDsrcGenericv7.asn" ]; then
    wget -P "$ETSI_ITS_BUILD_ROOT_DIR"/asn1 'https://standards.iso.org/iso/14906/ed-3/en/ISO14906(2018)EfcDsrcGenericv7.asn'
  fi
  if [ ! -f "$ETSI_ITS_BUILD_ROOT_DIR"/asn1/TS17419_2014_CITSapplMgmtIDs.asn ]; then
    wget -P "$ETSI_ITS_BUILD_ROOT_DIR"/asn1 'https://standards.iso.org/iso/ts/17419/TS%2017419%20ASN.1%20repository/TS17419_2014_CITSapplMgmtIDs.asn'
  fi
  if [ ! -f "$ETSI_ITS_BUILD_ROOT_DIR"/asn1/"ISO14906(2018)EfcDsrcGenericv7.asn" ]; then
    wget -P "$ETSI_ITS_BUILD_ROOT_DIR"/asn1 'https://standards.iso.org/iso/14906/ed-3/en/ISO14906(2018)EfcDsrcGenericv7.asn'
  fi

ISO14823-missing.asn will not be present

function compile_IVIM() {
  install -d "$VC_ITS_LIB_ROOT_DIR"/ivim
  asn1c -D "$VC_ITS_LIB_ROOT_DIR"/ivim -R -no-gen-example -fcompound-names -fno-include-deps -pdu=IVIM \
    "$VC_ITS_ASN1_SPECS_DIR"/"$IVIM_SPEC" \
    "$VC_ITS_ASN1_SPECS_DIR"/"$CDD_SPEC_v2" \
    "$IS_TS_ISO_DIR"/'ISO24534-3_ElectronicRegistrationIdentificationVehicleDataModule-patched.asn' \
    "$IS_TS_ISO_DIR"/'ISO14823-missing.asn' \
    "$ADDITIONAL_MODULES_DIR"/'TS17419_2014_CITSapplMgmtIDs.asn' \
    "$IS_TS_ISO_DIR"/'ISO14906(2018)EfcDsrcGenericv7-patched.asn' \
    "$IS_TS_ISO_DIR"/'ISO14906(2018)EfcDsrcApplicationv6-patched.asn' \
    "$ADDITIONAL_MODULES_DIR"/'ISO-TS-19091-addgrp-C-2018-patched.asn' \
    "$ADDITIONAL_MODULES_DIR"/'ISO14816_AVIAEINumberingAndDataStructures.asn' \
    "$ADDITIONAL_MODULES_DIR"/'ISO19321IVIv2.asn'

  install -d "$VC_ITS_LIB_ROOT_DIR"/ivim/src
  mv "$VC_ITS_LIB_ROOT_DIR"/ivim/*.c "$VC_ITS_LIB_ROOT_DIR"/ivim/src/

  echo "Compiled PDU: IVIM"
}

Original ETSI forge source

One file is loaded twice.

if [ ! -f 'build/asn1/ISO14906(2018)EfcDsrcGenericv7.asn' ]; then
  wget -P build/asn1 'https://standards.iso.org/iso/14906/ed-3/en/ISO14906(2018)EfcDsrcGenericv7.asn'
fi
if [ ! -f 'build/asn1/TS17419_2014_CITSapplMgmtIDs.asn' ]; then
  wget -P build/asn1 'https://standards.iso.org/iso/ts/17419/TS%2017419%20ASN.1%20repository/TS17419_2014_CITSapplMgmtIDs.asn'
fi
if [ ! -f 'build/asn1/ISO14906(2018)EfcDsrcGenericv7.asn' ]; then
  wget -P build/asn1 'https://standards.iso.org/iso/14906/ed-3/en/ISO14906(2018)EfcDsrcGenericv7.asn'
fi

ISO14823-missing.asn will not be present

install -d build/ivim
asn1c -D build/ivim -R -no-gen-example -fcompound-names \
	'IVIM-PDU-Descriptions.asn' \
	'cdd/ITS-Container.asn' \
	'iso-patched/ISO24534-3_ElectronicRegistrationIdentificationVehicleDataModule-patched.asn' \
	'iso-patched/ISO14823-missing.asn' \
	'build/asn1/TS17419_2014_CITSapplMgmtIDs.asn' \
	'iso-patched/ISO14906(2018)EfcDsrcGenericv7-patched.asn' \
	'iso-patched/ISO14906(2018)EfcDsrcApplicationv6-patched.asn' \
	'build/asn1/ISO-TS-19091-addgrp-C-2018-patched.asn' \
	'build/asn1/ISO14816_AVIAEINumberingAndDataStructures.asn' \
	'build/asn1/ISO19321IVIv2.asn' \

Effects and Solution

The missing file does not seem to affect the library. However, there might be elements missing.

These might be the correct files.

Status

More information needed. There was not yet an issue. This is only an observation.