Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CRA react-scripts 5.x.x #4018

Closed
antgamdia opened this issue Jan 3, 2022 · 1 comment · Fixed by #4802
Closed

Update to CRA react-scripts 5.x.x #4018

antgamdia opened this issue Jan 3, 2022 · 1 comment · Fixed by #4802
Assignees
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature

Comments

@antgamdia
Copy link
Contributor

Description:

PRs intended to reduce some security issues (like #4011 ) are being rejected due to the non-trivial required effort. The main problem is react-scrips upgrading webpack to the major release 5. There are two types of problems:

My current recommendation is to wait until the CRA team come up with a recommendation for both sort of problems.

Steps to reproduce the issue:

  1. Update to CRA >= 5.0.0

Describe the results you received:

The app cannot be started or built.

Describe the results you expected:

Everything up and running.

@castelblanque
Copy link
Collaborator

More info about react-scripts 4.x vulnerabilities in #4502

@castelblanque castelblanque changed the title Update to CRA 5.x.x Update to CRA react-scripts 5.x.x Mar 28, 2022
@ppbaena ppbaena added next-iteration Issues to be discussed in planning session and removed next-iteration Issues to be discussed in planning session labels Mar 28, 2022
@antgamdia antgamdia self-assigned this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants