Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Control Service] Come up with a safer approach to job image configuration in helm chart #2100

Closed
doks5 opened this issue May 22, 2023 · 1 comment
Labels

Comments

@doks5
Copy link
Contributor

doks5 commented May 22, 2023

What is the feature request? What problem does it solve?
With the introduction of the deploymentSupportedPythonVersions configuration, the fqdn of the image registry became part of the configuration map, instead of the previously used composite configuration approach.

This causes a situation, where the registry and its associated credentials need to be set in a separate configuration, thus leading to the possibility of unexpected errors, as mentioned in #2075 (comment)

We need to figure out a way to validate that the registries in the deploymentSupportedPythonVersions configuration are the same as the ones used for setting up the secrets.

Suggested solution
TBD

Additional context
Add any other context or screenshots about the feature request here.

@sabadzhiev
Copy link

Triaged. Closed as stale.

@sabadzhiev sabadzhiev closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants