Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drill and Surface 3D Refactoring #41

Open
3 tasks
giannissc opened this issue May 9, 2023 · 0 comments
Open
3 tasks

Drill and Surface 3D Refactoring #41

giannissc opened this issue May 9, 2023 · 0 comments
Labels
op:drill Operation: Drill op:surface3d Operation: Surface3D quality Achievement unlocked: Shoe polish

Comments

@giannissc
Copy link
Contributor

giannissc commented May 9, 2023 •
edited
Loading

  • Drill and Surface3D are classes but profile and pocket are method. Should we be consistent?
  • There is an Operation class in base_operation and an Operation in fluent.
  • Remove dataclass
@giannissc giannissc mentioned this issue May 9, 2023
Open
4 tasks
@voneiden voneiden added op:surface3d Operation: Surface3D op:drill Operation: Drill quality Achievement unlocked: Shoe polish labels May 9, 2023
@giannissc giannissc mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
op:drill Operation: Drill op:surface3d Operation: Surface3D quality Achievement unlocked: Shoe polish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voneiden @giannissc