Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private Textmate grammar tokenization #15

Closed
2 tasks done
zm-cttae opened this issue Feb 24, 2023 · 5 comments
Closed
2 tasks done

Support private Textmate grammar tokenization #15

zm-cttae opened this issue Feb 24, 2023 · 5 comments
Assignees
Milestone

Comments

@zm-cttae
Copy link
Member

⚡️️ Feature Request

  • I'm using the latest version of vscode-textmate-languageservice available.
  • I searched existing issues, open & closed. Yes, my feature request is new.

Is your feature request related to a problem?

Some folk over at the VS Code Development Community Slack would like to tokenize TypeScript.

Describe the solution you'd like

Just throw in textmate-languageservice-contributes alias for contributes key in package.json.

This would allow identical wiring for the language scope & its Textmate grammar.

Describe alternatives you've considered

Not support the use case but if we're publicising the token service, it needs dev support..

@zm-cttae
Copy link
Member Author

changed due date to March 01, 2023

@zm-cttae
Copy link
Member Author

mentioned in commit 8f09717

@zm-cttae
Copy link
Member Author

zm-cttae commented Mar 8, 2023

  • We can't fetch core resources in web runtime using readFile for what its worth.
  • This makes a path variable like $appRoot / %APPROOT% unusable.
  • Ideally however, relying on core resources is not wise as VS Code team can decide to restructure their entire app or Node dependency wiring.

@zm-cttae
Copy link
Member Author

Work was completed for this in !9.

@zm-cttae
Copy link
Member Author

Published in 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant