Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sku-selector is rerendering the parent silde #1077

Open
elian-dev opened this issue Feb 28, 2023 · 0 comments
Open

sku-selector is rerendering the parent silde #1077

elian-dev opened this issue Feb 28, 2023 · 0 comments

Comments

@elian-dev
Copy link

Describe the bug
When I have a "product-summary-sku-selector" in a shelf with the display mode "slider", is rerendering the parent shelf instead of the variants. If I do a click in the arrow to view more, is showing the parent shelf inside the card.

To Reproduce
Steps to reproduce the behavior:

  1. I have the product summary sku selector like this:
"product-summary-sku-selector#iphones": {
    "props": {
      "variationsSpacing": 5 ,
      "showValueNameForImageVariation": false,
      "hideImpossibleCombinations": true,
      "showVariationsLabels": false,
      "visibility": "more-than-one",
      "initialSelection": "complete",
      "disableUnavailableSelectOptions": true,
      "sliderItemsPerPage": {
        "desktop": 3,
        "tablet": 3,
        "phone": 3
      },
      "thumbnailImage": [
        "COLOR"
      ],
      "blockClass": "sku-selector-iphones",
      "displayMode": "slider",
      "sliderDisplayThreshold": 3,
      "visibleVariations": [
        "Color",
        "Contenido",
        "Capacidad (ROM)",
        "Valor",
        "Selecciona una talla",
        "Talla calzado",
        "Talla Damas",
        "Talla Caballeros"
      ]
    }
  }
  1. That product-summary-sku-selector is called into a shelf summary like this:
"product-summary.shelf": {
        "children": [
          "product-summary-sku-selector#iphones"
        ]
      }
  1. So I think that the error is because the behavior of the parent shelf's slider is confusing with the slider that is rendered into the summary.
    The parent shelf's slider have these properties:
//LIST CONTEXT
"list-context.product-list#home-shelf": {
    "blocks": [
      "product-summary.shelf"
    ],
    "children": [
      "slider-layout#demo-products",
      "add-to-list-btn"
    ],
    "props": {
      "collection": "203",
      "maxItems": 10,
      "skusFilter": "ALL_AVAILABLE",
      "installmentCriteria": "MAX_WITHOUT_INTEREST",
      "orderBy": "OrderByTopSaleDESC"
    }
  },

//SLIDE LAYOUT
"slider-layout#demo-products": {
    "props": {
      "itemsPerPage": {
        "desktop": 5,
        "tablet": 3,
        "phone": 2
      },
      "showPaginationDots": "never",
      "infinite": true,
      "fullWidth": true,
      "blockClass": "list-home-shelf-slider",
      "label": "productos"
    }
  },

Expected behavior
I expect that if I click an arrow of the sku selector view just the variants.

Screenshots
image
ezgif-1-eaebcc3ad7

Desktop (please complete the following information):
I'm using:

  • OS: window
  • Browser: chrome

[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant