Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication between v1 and v2 process-test-directory builders #1089

Open
howard-e opened this issue Jul 16, 2024 · 0 comments
Open

Reduce duplication between v1 and v2 process-test-directory builders #1089

howard-e opened this issue Jul 16, 2024 · 0 comments
Assignees

Comments

@howard-e
Copy link
Contributor

[...] on duplication between lib/data/process-test-directory.js and lib/data/process-test-directory-v1.js [...]:

v1 csv resources and references eventually won't exist so there won't be a need to build them. A couple v1 files have already been removed since introducing v2

So separating that into dedicated orchestrating scripts for the v1 and v2 test formats rather than creating branches in a single file that we may want to eventually prune in the future seemed much easier to do

Some parts are similar enough though that the functions could be consolidated in a single util and used separately

[...]

Originally posted by @jugglinmike in #907 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In production / Completed
Development

No branches or pull requests

1 participant