Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior after a failed call to cropTo() #77

Open
eladalon1983 opened this issue Mar 9, 2023 · 0 comments
Open

Behavior after a failed call to cropTo() #77

eladalon1983 opened this issue Mar 9, 2023 · 0 comments

Comments

@eladalon1983
Copy link
Member

eladalon1983 commented Mar 9, 2023

Consider a track cropped-to cropTarget1. Assume a valid cropTarget2 is produced to match element2, then element2 is removed from the DOM and eventually garbage-collected. If we now call track.cropTo(cropTarget2), it would return a rejected promise. But what should happen with track? Should it keep issuing frames cropped to cropTarget1, or should it be muted?

(FWIW, Chrome's current behavior is that the track no longer issues new frames. Up for debate if that's desirable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant