Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 wheels for Windows and Linux #9

Closed
laggykiller opened this issue Feb 1, 2024 · 4 comments · Fixed by #10
Closed

arm64 wheels for Windows and Linux #9

laggykiller opened this issue Feb 1, 2024 · 4 comments · Fixed by #10
Assignees
Labels
enhancement New feature or request

Comments

@laggykiller
Copy link
Contributor

May I request for building arm64 wheels for Windows and Linux? Should be easy by specifying CIBW_ARCHS_WINDOWS and CIBW_ARCHS_LINUX. Thank you!

@flozz flozz self-assigned this Feb 2, 2024
@flozz flozz added the enhancement New feature or request label Feb 2, 2024
@flozz
Copy link
Member

flozz commented Feb 2, 2024

Hello,

According to the doc, it seems to be a bit more complicated than to just add an env var (at least for Linux it seems we have to setup some emulation with qemu).

I will not have time to do it right now, but I added it to my TODO list, I will try to add this in a few weeks.
Thank you for the suggestion :)

@laggykiller
Copy link
Contributor Author

laggykiller commented Feb 2, 2024

Your library builds with cffi without other dependencies. When CIBW_ARCHS is passed to cibw, it automatically sets compiler environment variables so cross-compilation occurs automatically (if it had other dependencies that are built by other tools, you have to manually add compiler flags and it is indeed a massive headache). For Linux, it's true that we have to set up qemu emulation, but it is as simple as adding a github action before building wheels.

I have opened a PR: #10

I have tested the github action and it works. The arm64 wheels for Windows and Linux both seem to work properly.

Build log: https://github.com/laggykiller/imagequant-python/actions/runs/7754413136

arm64 wheels for testing: https://github.com/laggykiller/imagequant-python/releases/tag/v1.1.0-1

@flozz
Copy link
Member

flozz commented Feb 2, 2024

Thank you for the PR, I will review it this afternoon and release new wheels if everything is ok! :)

@flozz flozz closed this as completed in #10 Feb 2, 2024
@flozz
Copy link
Member

flozz commented Feb 2, 2024

Published as v1.1.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants