Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql-analysis.yml #256

Merged
merged 11 commits into from
Apr 8, 2024
Merged

Create codeql-analysis.yml #256

merged 11 commits into from
Apr 8, 2024

Conversation

jukie
Copy link
Collaborator

@jukie jukie commented Jun 29, 2022

Adds code scanning for vulnerabilities like the ones discovered by a user in #254

@yermulnik
Copy link
Collaborator

  1. Should we exclude non-Golang paths to Avoid unnecessary scans of pull requests? Like e.g. in this PR CodeQL sort of blocks this PR whereas this PR has nothing to do with the alerted file.
  2. Also is there an option for CodeQL to ignore some code lines, blocks and snippets? I was able to only find how to ignore files, but couldn't find an option for inline comments to disable check for specific fragments of code 🤷🏻 Like for when we do want or need some flagged code block to remain as is.

@jukie
Copy link
Collaborator Author

jukie commented Jun 29, 2022

Yeah I need to clean this up @yermulnik, converting to draft

@jukie jukie marked this pull request as draft June 29, 2022 15:41
@MatrixCrawler MatrixCrawler reopened this Apr 8, 2024
@MatrixCrawler
Copy link
Collaborator

I rebased and updated the codeql defintion. Maybe we should go forward with this?

@yermulnik
Copy link
Collaborator

Maybe we should go forward with this?

I'm fine with this going forward.
@jukie seems to has been inactive for some time 😢, so we may need to proceed on our own.

@MatrixCrawler MatrixCrawler marked this pull request as ready for review April 8, 2024 12:30
.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
Co-authored-by: George L. Yermulnik <[email protected]>
@jukie
Copy link
Collaborator Author

jukie commented Apr 8, 2024

Thanks @yermulnik! Looks like a lot of activity here, I'll start getting involved again

@yermulnik
Copy link
Collaborator

Thanks @yermulnik! Looks like a lot of activity here, I'll start getting involved again

Yay, that's great 🥳

@MatrixCrawler MatrixCrawler merged commit 65dbada into master Apr 8, 2024
2 checks passed
@MatrixCrawler MatrixCrawler deleted the add-codeql-scans branch April 8, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants