Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Workflow fix #360

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

MatrixCrawler
Copy link
Collaborator

It seems that the version update only works over the PR way. With this i try to solve that problem.

@MatrixCrawler
Copy link
Collaborator Author

I would like to let @warrensbox make the merge.
It might be necessary to exempt PR that are created by GitHub actions from the "needs two reviews" restrictions

@MatrixCrawler MatrixCrawler added the enhancement Refactor existing code for better performance and quality label Apr 5, 2024
@warrensbox
Copy link
Owner

Let me test this first on another repo

@warrensbox
Copy link
Owner

warrensbox commented Apr 8, 2024

I cannot get this to work right. What is the purpose of this again?

@MatrixCrawler
Copy link
Collaborator Author

You are changing the version file in the workflow, but github does not allow pushes on the master branch directly. Changes have to be done via a PR.
This fix should create a temporary release-branch, a PR and merge this PR automatically to update the Version file.

@warrensbox warrensbox merged commit 2742b8e into warrensbox:master Apr 10, 2024
@MatrixCrawler MatrixCrawler added this to the Release 1.1.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactor existing code for better performance and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants