Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming convention, or possibly a typo? #182

Open
lorenseanstewart opened this issue Nov 16, 2018 · 1 comment
Open

Inconsistent naming convention, or possibly a typo? #182

lorenseanstewart opened this issue Nov 16, 2018 · 1 comment

Comments

@lorenseanstewart
Copy link

I notice that in story.json the language property ref points to trait_locale.json.

I propose either

  1. changing the name the reference to trait_language, or
  2. change the story property to locale.

This is to make the link between the two more clear, and to make it consistent with the pattern of the other references.
@gengel
Copy link
Collaborator

gengel commented Nov 23, 2018

Agreed, this is confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gengel @lorenseanstewart