Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems not working? #1

Open
mayli opened this issue Jan 31, 2022 · 9 comments
Open

Seems not working? #1

mayli opened this issue Jan 31, 2022 · 9 comments

Comments

@mayli
Copy link
Contributor

mayli commented Jan 31, 2022

After mod installed, with microsoft default IME
image

@way-zer
Copy link
Owner

way-zer commented Feb 2, 2022

WIndows version? x64?
if is win10/11 x64, attach system32/msctf.dll

I have tested on win10 x64.
Snipaste_2022-02-02_13-42-20

@way-zer
Copy link
Owner

way-zer commented Feb 19, 2022

no reply

@way-zer way-zer closed this as completed Feb 19, 2022
@mayli
Copy link
Contributor Author

mayli commented Feb 19, 2022

WIndows version? x64? if is win10/11 x64, attach system32/msctf.dll

I have tested on win10 x64. Snipaste_2022-02-02_13-42-20

msctf.zip

Windows 10 Pro x64 20H2, English.

@mayli
Copy link
Contributor Author

mayli commented Feb 19, 2022

50% working with the official client, it has the input hook, but doesn't display the input selections at the mod selection page
image

Seems working at the nick change input on server join dialog
image
however pressing space on the selection will input "???" instead of the right inputs
image
It might caused due to using English locale on my Windows.

0% working with the foo's client, same behavior as without the mod.
:(

@way-zer way-zer reopened this Feb 20, 2022
@way-zer
Copy link
Owner

way-zer commented Feb 20, 2022

For foo

fix in v1.3.2, see #2 .

For 50% in offfical client

see #3, this is known limit. See you successfully open compositeWindow, hook to msctf is OK

For '???'

I don't know why, and no other report it, using Chinese locale.
And mod do nothing to input, Just make it visible.

If you use offfical client without mod, input without compositeWindow, show chars not '???', tell me.

@mayli
Copy link
Contributor Author

mayli commented Feb 22, 2022

Both the official client and foo's can take proper input text from IME to chat, however they don't have the candidate selection popup :(

@mayli
Copy link
Contributor Author

mayli commented Feb 23, 2022

With universal unicode off + English Locale
-> ???

With universal unicode on
image

image
ZQPgo6UqWR

It seems to be some encoding issue

After setting locale chinese
image
image

It could be the dll or the code have some assumption of local locale, and doesn't use Unicode to encode the text.

@way-zer
Copy link
Owner

way-zer commented Feb 23, 2022

If it works with english locale in origin client, it may be:

I block some IME event to libsdl, may cause that can't recoginaze local locale.

@way-zer
Copy link
Owner

way-zer commented Mar 31, 2022

@mayli
Could you try this build? See it can resolve locale problem or not. I can't reproduce this problem locally.
IME_Fixer.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants