Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Error handlers allow "flow_input" as argument, but not "results" #3884

Open
wasnertobias opened this issue Jun 7, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@wasnertobias
Copy link

Describe the bug

Highlighting is still broken for "flow_input".

Example flow attached.

To reproduce

summary: ""
description: ""
value:
  modules:
    - id: b
      value:
        lock: ""
        type: rawscript
        content: |-
          # import wmill


          def main(x: str):
              return x + "someone"
        language: python3
        input_transforms:
          x:
            expr: flow_input.x
            type: javascript
        tag: ""
    - id: a
      value:
        tag: ""
        lock: ""
        type: rawscript
        content: |-
          # import wmill


          def main(x: str):
              raise Exception("ignore this please!")
        language: python3
        input_transforms:
          x:
            type: static
            value: ""
  failure_module:
    id: failure
    value:
      tag: null
      type: rawscript
      content: |
        # import wmill
        import logging

        logging.basicConfig(level=logging.INFO)

        def main(x: str, x2: str):
            logging.info("Got some" + x)
            logging.info(x2)
      language: python3
      input_transforms:
        x:
          expr: flow_input.x
          type: javascript
        x2:
          expr: results.b
          type: javascript
schema:
  $schema: https://json-schema.org/draft/2020-12/schema
  properties:
    x:
      type: string
      description: asdf
      default: ""
      format: ""
  required: []
  type: object
  order:
    - x

Expected behavior

image Step input not underlined red if flow_input is used, as it apparently works. It would be nice to have access to step results that succeeded.

Screenshots

No response

Browser information

No response

Application version

No response

Additional Context

No response

@wasnertobias wasnertobias added the bug Something isn't working label Jun 7, 2024
@wasnertobias wasnertobias changed the title bug: Error handlers allow flow_input as argument, but not results bug: Error handlers allow "flow_input" as argument, but not "results" Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants