Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: integrations array is non-communicative #3611

Closed
1 task done
seanaye opened this issue Jun 16, 2022 · 2 comments
Closed
1 task done

🐛 BUG: integrations array is non-communicative #3611

seanaye opened this issue Jun 16, 2022 · 2 comments
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope)

Comments

@seanaye
Copy link

seanaye commented Jun 16, 2022

What version of astro are you using?

1.0.0-beta.46

Are you using an SSR adapter? If so, which one?

null

What package manager are you using?

repro'd on both pnpm and npm

What operating system are you using?

Repro'd in Stackblitz in Chrome and MacOS 12.4

Describe the Bug

The integrations array in astro.config.js is non-communicative.

Using both the solid-js and preact adapters will break if the solid adapter comes before the preact adapter.

e.g.

// valid configuration, renders components correctly
export default defineConfig({
  integrations: [preact(), solid(), tailwind()],
});
// invalid. 
// local machine pnpm this causes preact component to not render at all (fails silently)
// in stackblitz i get vite error `Cannot read properties of undefined (reading '__H')`
export default defineConfig({
  integrations: [solid(), preact(), tailwind()],
});

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-gvag35?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) - P3: minor bug An edge case that only affects very specific usage (priority) labels Jun 20, 2022
@tony-sull
Copy link
Contributor

I've seen a couple questions pop up related to SolidJS and Preact. I'm wondering if this is related to the two libraries stepping on each other's babel configs or something similar 🤔

[triage] Leaving a sizing estimate off this issue for now, needs a bit more investigation on our end to better understand the underlying issue here

@tony-sull
Copy link
Contributor

Confirmed this is actually fixed in the RC 🎉 I'm not 100% sure, but I have a hunch this was fixed by the upgrade from Vite 2 -> Vite 3

Updated reproduction from #4033 now works with the latest RC release and framework integrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope)
Projects
None yet
Development

No branches or pull requests

2 participants