-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function blackmarbler::bm_extract is not downloading #10
Comments
Just to clarify, the function is always downloading to temporal files but not to the folder defined in |
@alexyshr Thanks for flagging this! The issue should be fixed in the dev version ( |
Thank you @ramarty. After reinstalling from GitHub. I am using the function as below:
Inside The process fails. I tried multiple times. The content of Thank you! |
The content of the Rds files is OK, but the combination of those results in long format inside the variable |
@alexyshr This is all helpful feedback. A couple things: 1/ After running the below code, do you get values for
2/ I'll update the documentation to make this more clear (or just update what the package does to give a more expected result). But when:
I've used Happy to clarify more, or let me know if the above code still doesn't work. Thanks! |
@ramarty Thank you! 1/ It returns data in
After re-downloading all the HDF5 files to temporary locations, the result is stored in
I was able to gather all the rds inside
4.1 If I change the
4.2 What if we have other Rds (not related) inside that folder. The integrated Rds will be wrong. For instance, an additional Rds created as below. Those files will provoke a bad result.
4.3 What if we change the geometry of 4.4 What if we change other parameters of the package commands? The Rds need to be recreated. I think a better solution could be:
Thank you! |
I thought that removing the Rds would be the solution to avoid re-downloading HDF5 files, but it seems that once no Rds are located inside
Thank you for your time. I am not in a hurry. Take your time. I know that this package is just starting. I will try working with HDF5 files directly using |
@alexyshr These are excellent comments — thanks so much. Great point about making variable names more unique—such as incorporating the And yep, definitely agree about returning the appended dataframe even when Helpful point too on wanting to keep the HDF5 files to, for example, extract multiple variables but avoid re-downloading the data (which can be slow). I'll think on the best way to implement this, but figure could add a function that just downloads HDF5 files to a directory, then could add an option in Thanks again — will work on making these improvements! |
Hi @ramarty , I have edited the current version in GitHub to avoid downloading HDF5 files if they exist in I know you are changing multiple things in the package (migration to TERRA) but I would like you to consider the changes that can be useful for the user. Please find the code attached. I did all the changes testing the function Main considerations:
You can test this version with the code below (those dates in the code have one missing tile for the Puerto Rico area)
|
@alexyshr thanks so much -- these changes are great & I agree makes sense. Aiming to go through this week, so should have an update by end of week! |
@alexyshr Apologies that its taken me forever to make changes, but few updates (on the development version -- not on cran yet)
I'll do some additional tests before updating these to CRAN -- but definitely let me know if you run into more issues or if have more feedback! (Also working on allowing one to use |
That is wonderful. I will check this tomorrow. Thank you! |
Hi there! The function does not download R files to file_dir. I installed it from GitHub. hdf5 files are downloaded to h5_dir.
|
Ah thanks for flagging! I'll look into the code and fix in the next day or so! |
Hi, As the code is working in a tryCatch it doesn't show errors. My errors were:
Is it possible to load the libraries in the initial part of each function?
in order to make next line to work
I have an additional question. What is the purpose of this The function Thanks Alexys |
Can you please advise me on why the function
blackmarbler::bm_extract
is not downloading the files as expected? Despite the system indicating that the files were processed 100%, no downloads are appearing in my designated folders. I used a local Administrator account on Windows 10 to run the R script, but no files are being written to the disk drive. I did not encounter any error messages or warnings during the execution of the script. I just installed the development version ofblackmarbler
package from GitHub, but It didn't work with the CRAN version either. I'm running the last R version [4.3.3]. Any assistance in resolving this issue would be greatly appreciated. I am using my NASA-EARTHDATA-TOKEN to define thebearer
variable.This is the outcome:
![error](https://private-user-images.githubusercontent.com/26773533/311394374-b4110aa6-2c14-4f95-a464-3c46b7de5793.JPG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5Mzc5MTYsIm5iZiI6MTcyNTkzNzYxNiwicGF0aCI6Ii8yNjc3MzUzMy8zMTEzOTQzNzQtYjQxMTBhYTYtMmMxNC00Zjk1LWE0NjQtM2M0NmI3ZGU1NzkzLkpQRz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDAzMDY1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEwMmYxNjNiNWMxYzIxOTkwMTg3YzIwODNjNGY1MTQ1YzQ3NTAxYjdmMzA2MjY3ZmFmNTgwMjNmNjdlMTFiM2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PBaRrtpwG-zPm-xYsNg41YFN-_cCEVfhMPtUBmYzHo8)
The text was updated successfully, but these errors were encountered: