Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Type field on ApiPropertyDocumentation #42

Open
georgehemmings opened this issue Apr 2, 2018 · 1 comment
Open

Data Type field on ApiPropertyDocumentation #42

georgehemmings opened this issue Apr 2, 2018 · 1 comment

Comments

@georgehemmings
Copy link
Contributor

I'd like the DataType field from ApiMemberAttribute to end up in the spec.

Would you be okay if I submit a pull request to add it? Do you have any preference on the property name?

@wwwlicious
Copy link
Owner

@georgehemmings yes, this shouldn't be an issue.

One thing to note on types in general in the spec is that for the next major version bump I'll need to make some breaking change around the type outputs anyway (both in the output names and relationships between types)

This became apparent when build the UI for the introspec output in terms of things like self referencing types (circular dependencies) and being able to cleanly identify user types from clr types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants