Don't hardcode /usr/include in meson.build

[rossburton]

If AppStream is build with stemmer enabled, it forcibly looks in /usr/include:

appstream/meson.build

Line 188 in 1217913

stemmer_inc_dirs = include_directories(['/usr/include'])

I may have installed stemmer anywhere, and in cross-compiled environments hardcoding this path is absolutely the wrong thing to do as it is the host includes not the target includes.

[ximion]

Patches welcome ;-)
Ideally Snowball would just ship a pkg-config file, but annoyingly it doesn't.

[rossburton]

Filed snowballstem/snowball#190 to nudge snowball maintainers.

[eli-schwartz]

Ideally Snowball would just ship a pkg-config file, but annoyingly it doesn't.

Ideally snowball would support installing anything at all, period.

However I am slightly curious why you need to specify any include directories at all. Do the compiler builtin defaults not work? That should already have /usr/include, but only on native builds, since in cross builds it will have /path/to/cross-sysroot/usr/include

And given that you don't know where snowball is installed without a pkg-config file, it seems 100% pointless to hardcode an arbitrary location that may not be true.

[rossburton]

Right, I'd have thought that the meson header/library checking code would have been sufficient to validate that the library is present.