Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation fails on developer IDs with uppercase #617

Open
A6GibKm opened this issue Mar 10, 2024 · 4 comments
Open

validation fails on developer IDs with uppercase #617

A6GibKm opened this issue Mar 10, 2024 · 4 comments

Comments

@A6GibKm
Copy link

A6GibKm commented Mar 10, 2024

The following:

  <developer id="io.github.Uppercase">
    <name>Hello</name>
  </developer>

produces a warning:

$ appstreamcli validate --explain app.metainfo.xml 
W: app.drey.Test:6: developer-id-invalid io.github.Uppercase
   The developer-ID is invalid. It should be an rDNS string identifying the developer, or a
   Fediverse handle. It must also only contain lowercase ASCII letters, numbers and punctuation.

The docs at https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer do not mention any requirement on lowercase vs uppercase.

Either the docs are missing info or the linter is not doing the right thing.

@sonnyp
Copy link

sonnyp commented Mar 10, 2024

Since using the app id as developer id will be a common use case - it would be pragmatic to allow upper case letters in the developer id.

See also https://matrix.to/#/!jcUJARuitCjSJLKnYP:gnome.org/$8oPWRH_nrNHPCDwQR4EaYYBU25ficM85cybtJ1n1_Y0

@A6GibKm
Copy link
Author

A6GibKm commented Mar 10, 2024

Note that @[email protected] would also fail. Can a Fediverse handle be case sensitive? If so it makes sense to allow uppercase in those.

@ximion
Copy link
Owner

ximion commented Mar 12, 2024

I agree, sorry for the delayed response! (I am very preoccupied at the moment)
We could make this an info hint, like with component-IDs, but TBH I think the better thing to do is to just drop the case check, especially since it does not follow the spec in that regard.

I faintly remember that we initially wanted to allow only lowercase, then dropped that, and it looks like I did not adjust the check (it was supposed to test only the domain part of the rDNS for case, not the whole string...).
Maybe I will get to it today, otherwise some time during the week :-)

@A6GibKm
Copy link
Author

A6GibKm commented Jul 1, 2024

Hello, is there any update to this? We are using the app id in some apps like e.g. Bustle

  <developer id="org.freedesktop.Bustle">
    <name>The Bustle developers</name>
  </developer>

Since the GNOME runtime now has a new enough appstream the app fails at CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants