Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail because product information changes #134

Open
ThomasProctor opened this issue Mar 28, 2018 · 0 comments
Open

tests fail because product information changes #134

ThomasProctor opened this issue Mar 28, 2018 · 0 comments

Comments

@ThomasProctor
Copy link

I just forked the repo and ran the tests, and unsurprisingly, lots of them fail... because they are dependent on the information about products not changing, but they do.

I'm not sure what the right solution here is. One option is to reduce the checks to type checks, and assume that, while the values might change (which I see a lot of), the presence of attributes will not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant