Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abstraction and create a Block class #18

Open
yunpengn opened this issue Mar 28, 2019 · 2 comments
Open

Use abstraction and create a Block class #18

yunpengn opened this issue Mar 28, 2019 · 2 comments
Labels
enhancement New feature or request refactor Some refactor for existing code

Comments

@yunpengn
Copy link
Owner

  • Background: in many places (such as BlockNestedJoin and Sort), we should operate on a higher-level rather than Batch. This is because, the number of buffer pages > 1.
  • Solution: for better SE practice, we should have a higher level of abstraction, i.e., create a Block class which consists of an array of Batches.
@yunpengn yunpengn added enhancement New feature or request refactor Some refactor for existing code labels Mar 28, 2019
@yunpengn yunpengn changed the title Use abstraction and create a Block class Use abstraction and create a Block class Mar 28, 2019
@dalessr
Copy link
Collaborator

dalessr commented Mar 29, 2019

Are we going to (or allowed to) add this layer in utils/?

@yunpengn
Copy link
Owner Author

We should be able to, right? This is just a refactor, it should NOT affect the correctness of the engine. Need to plan carefully before implement this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor Some refactor for existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yunpengn @dalessr