Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: setVolume triggers an error if no song has been loaded yet #212

Open
yvesgurcan opened this issue Apr 11, 2020 · 0 comments
Open

Bug: setVolume triggers an error if no song has been loaded yet #212

yvesgurcan opened this issue Apr 11, 2020 · 0 comments

Comments

@yvesgurcan
Copy link
Owner

Environment

  • Version of web-midi-player: 1.3.11
  • Browser: Chrome
  • Operating system: MacOS
  • Device model: iMac

Bug

Describe the issue as specifically as possible.

This bug is visible on the React example of the library. If you try to update the volume of the player before attempting to load a song, the code will trigger an error and not update the volume.

Expected behavior

What did you expect to happen?

The volume should be updated to the correct value and not trigger an error. Also, the song that I play after setting the volume should be played at the new volume.

Screenshot

Screen Shot 2020-04-10 at 10 13 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant