Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.9.4: invalid flag in #cgo CFLAGS: -fno-common #3

Open
lloeki opened this issue Feb 12, 2018 · 2 comments
Open

Go 1.9.4: invalid flag in #cgo CFLAGS: -fno-common #3

lloeki opened this issue Feb 12, 2018 · 2 comments

Comments

@lloeki
Copy link

lloeki commented Feb 12, 2018

Caused by a security update to 1.9.4 which needs whitelisting. Reported upstream.

go build github.com/zchee/docker-machine-driver-xhyve/vendor/github.com/zchee/libhyperkit: invalid flag in #cgo CFLAGS: -fno-common

To work around this while the whitelisted flags get updated it may be possible to use $CGO_CFLAGS_ALLOW, otherwise one needs to go back to 1.9.3.

@youurayy
Copy link

Yes, builds with:

CGO_CFLAGS_ALLOW="-arch|x86_64|-fmessage-length=152|-fdiagnostics-show-note-include-stack|-fmacro-backtrace-limit=0" CGO_LDFLAGS_ALLOW="-arch|x86_64" make

I've seen the -arch reported upstream, the others may still need to get reported.

@lloeki
Copy link
Author

lloeki commented Mar 21, 2018

the others may still need to get reported.

Indeed. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants